Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Unified Diff: tracing/tracing/value/ui/iteration_info_span.html

Issue 2341623002: Display Histograms in value-set-table-cells. (Closed)
Patch Set: . Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tracing/tracing/value/ui/histogram_span.html ('k') | tracing/tracing/value/ui/numeric_stats_span.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/value/ui/iteration_info_span.html
diff --git a/tracing/tracing/value/ui/iteration_info_span.html b/tracing/tracing/value/ui/iteration_info_span.html
index aa25b08aa0943d8f5526b04a0938a26247725bb7..6b7d52be4b17040454c19923c82137b6e23a35f7 100644
--- a/tracing/tracing/value/ui/iteration_info_span.html
+++ b/tracing/tracing/value/ui/iteration_info_span.html
@@ -49,26 +49,41 @@ Polymer({
return;
}
- var rows = [
- ['benchmark name', this.diagnostic.benchmarkName],
- ['benchmark start', this.diagnostic.benchmarkStartString],
- ['url', this.diagnostic.storyUrl],
- ['story', this.diagnostic.storyDisplayName],
- ['storyset repeat', this.diagnostic.storysetRepeatCounter],
- ['story repeat', this.diagnostic.storyRepeatCounter],
- ];
+ var rows = [];
- if (this.diagnostic.label)
+ if (this.diagnostic.osVersion) {
+ rows.push(['OS version', this.diagnostic.osVersion]);
+ }
+ if (this.diagnostic.productVersion) {
+ rows.push(['product version', this.diagnostic.productVersion]);
+ }
+ if (this.diagnostic.benchmarkName) {
+ rows.push(['benchmark name', this.diagnostic.benchmarkName]);
+ }
+ if (this.diagnostic.benchmarkStart) {
+ rows.push(['benchmark start', this.diagnostic.benchmarkStartString]);
+ }
+ if (this.diagnostic.storyUrl) {
+ rows.push(['url', this.diagnostic.storyUrl]);
+ }
+ if (this.diagnostic.storyDisplayName) {
+ rows.push(['story', this.diagnostic.storyDisplayName]);
+ }
+ if (this.diagnostic.storysetRepeatCounter !== undefined) {
+ rows.push(['storyset repeat', this.diagnostic.storysetRepeatCounter]);
+ }
+ if (this.diagnostic.storyRepeatCounter !== undefined) {
+ rows.push(['story repeat', this.diagnostic.storyRepeatCounter]);
+ }
+ if (this.diagnostic.label) {
rows.push(['label', this.diagnostic.label]);
-
+ }
if (this.diagnostic.storyGroupingKeys &&
(tr.b.dictionaryLength(this.diagnostic.storyGroupingKeys) > 0)) {
var gov = document.createElement('tr-ui-a-generic-object-view');
gov.object = this.diagnostic.storyGroupingKeys;
rows.push(['grouping keys', gov]);
}
-
- rows.sort((x, y) => x[0].localeCompare(y[0]));
this.$.table.tableRows = rows;
}
});
« no previous file with comments | « tracing/tracing/value/ui/histogram_span.html ('k') | tracing/tracing/value/ui/numeric_stats_span.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698