Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: tracing/tracing/value/ui/scalar_span.html

Issue 2341623002: Display Histograms in value-set-table-cells. (Closed)
Patch Set: . Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tracing/tracing/value/ui/scalar_map_table_test.html ('k') | tracing/tracing/value/ui/scalar_span_test.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/value/ui/scalar_span.html
diff --git a/tracing/tracing/value/ui/scalar_span.html b/tracing/tracing/value/ui/scalar_span.html
index 7e3e970ff9b4ce757da1869c8cb76ce058a33c67..2b78ddbf4fd894aff0aca02fa4e536a7c099599b 100644
--- a/tracing/tracing/value/ui/scalar_span.html
+++ b/tracing/tracing/value/ui/scalar_span.html
@@ -19,7 +19,7 @@ tr.exportTo('tr.v.ui', function() {
* @param {!tr.b.Range=} opt_config.customContextRange
* @param {boolean=} opt_config.rightAlign
* @param {!tr.b.Unit=} opt_config.unit
- * @param {tr.v.Significance=} opt_config.significance
+ * @param {tr.b.Statistics.Significance=} opt_config.significance
* @param {string=} opt_config.contextGroup
* @return {(string|!HTMLElement)}
*/
@@ -221,7 +221,7 @@ Polymer({
this.context_ = undefined;
this.warning_ = undefined;
- this.significance_ = tr.v.Significance.DONT_CARE;
+ this.significance_ = tr.b.Statistics.Significance.DONT_CARE;
// To avoid unnecessary DOM traversal, search for the context controller
// only when necessary (when the span is attached and has a context group).
@@ -489,17 +489,17 @@ Polymer({
Polymer.dom(this.$.content).classList.add(changeClass);
switch (this.significance) {
- case tr.v.Significance.DONT_CARE:
+ case tr.b.Statistics.Significance.DONT_CARE:
break;
- case tr.v.Significance.INSIGNIFICANT:
+ case tr.b.Statistics.Significance.INSIGNIFICANT:
if (changeClass !== 'same')
title = 'insignificant ' + title;
this.$.insignificant.style.display = 'inline';
changeClass = 'same';
break;
- case tr.v.Significance.SIGNIFICANT:
+ case tr.b.Statistics.Significance.SIGNIFICANT:
if (changeClass === 'same')
throw new Error('How can no change be significant?');
this.$['significantly_' + changeClass].style.display = 'inline';
« no previous file with comments | « tracing/tracing/value/ui/scalar_map_table_test.html ('k') | tracing/tracing/value/ui/scalar_span_test.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698