Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Unified Diff: tracing/tracing/ui/base/column_chart.html

Issue 2341623002: Display Histograms in value-set-table-cells. (Closed)
Patch Set: . Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tracing/tracing/ui/base/chart_base_2d.html ('k') | tracing/tracing/ui/base/column_chart_test.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/ui/base/column_chart.html
diff --git a/tracing/tracing/ui/base/column_chart.html b/tracing/tracing/ui/base/column_chart.html
index deaf44a55bf214f9e263e2225ec804ba2f93118f..f695de90958a67b34ca89923872c069370b41f80 100644
--- a/tracing/tracing/ui/base/column_chart.html
+++ b/tracing/tracing/ui/base/column_chart.html
@@ -14,19 +14,6 @@ tr.exportTo('tr.ui.b', function() {
var ColorScheme = tr.b.ColorScheme;
var ChartBase2DBrushX = tr.ui.b.ChartBase2DBrushX;
- function getSVGTextWidth(parentNode, text) {
- var textNode = document.createElementNS(
- 'http://www.w3.org/2000/svg', 'text');
- textNode.setAttributeNS(null, 'x', 0);
- textNode.setAttributeNS(null, 'y', 0);
- textNode.setAttributeNS(null, 'fill', 'black');
- textNode.appendChild(document.createTextNode(text));
- parentNode.appendChild(textNode);
- var widthPx = textNode.getComputedTextLength();
- parentNode.removeChild(textNode);
- return widthPx;
- }
-
// @constructor
var ColumnChart = tr.ui.b.define('column-chart', ChartBase2DBrushX);
@@ -177,10 +164,11 @@ tr.exportTo('tr.ui.b', function() {
var keyWidthPx = 0;
var keyHeightPx = 0;
if (seriesKeys.length > 1) {
- keyWidthPx = getSVGTextWidth(this.chartAreaElement, rect.key) + 5;
+ keyWidthPx = tr.ui.b.getSVGTextWidth(
+ this.chartAreaElement, rect.key) + 5;
keyHeightPx = 16;
}
- var valueWidthPx = getSVGTextWidth(
+ var valueWidthPx = tr.ui.b.getSVGTextWidth(
this.chartAreaElement, rect.value) + 5;
var valueHeightPx = 16;
var hoverLeftPx = rect.leftPx + (rect.widthPx / 2);
@@ -255,7 +243,6 @@ tr.exportTo('tr.ui.b', function() {
return {
ColumnChart: ColumnChart,
- getSVGTextWidth: getSVGTextWidth
};
});
</script>
« no previous file with comments | « tracing/tracing/ui/base/chart_base_2d.html ('k') | tracing/tracing/ui/base/column_chart_test.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698