Reland of 🍵 Refactor the various locale_paks() templates to be more shared

Reland of Refactor the various locale_paks() templates to be more shared

Reverted by:
https://codereview.chromium.org/2340673002/

Reason for reland:
Now gn gens for enable_resource_whitelist_generation = true

Main motivation for this is to more easily add per-target
repack_whitelist.

TBR=michaelbai@chromium.org,thakis@chromium.org,sdefresne@chromium.org,estevenson@chromium.org,rsesek@chromium.org,brettw@chromium.org
BUG=645716
Committed: https://crrev.com/d83512c644c7c61331a32c97ba549fcb1d8793cb
Cr-Commit-Position: refs/heads/master@{#418450}

[agrieve, 2016-09-14 00:02:06]

Created Reland of 🍵 Refactor the various locale_paks() templates to be more
shared

[agrieve, 2016-09-14 00:06:44]

Description was changed from

==========
Reland of 🍵 Refactor the various locale_paks() templates to be more shared
(patchset #1 id:1 of https://codereview.chromium.org/2340673002/ )

Reason for revert:
Will update when fixed

Original issue's description:
> Revert of 🍵 Refactor the various locale_paks() templates to be more shared
(patchset #7 id:120001 of https://codereview.chromium.org/2320883006/ )
> 
> Reason for revert:
> gn gen fails when enable_resource_whitelist_generation=true
> 
> Original issue's description:
> > Refactor the various locale_paks() templates to be more shared
> >
> > Main motivation for this is to more easily add per-target
> > repack_whitelist.
> >
> > BUG=645716
> >
> > Committed: https://crrev.com/61973f5b2e2d7cf070c89043768b4a3e0025b19a
> > Cr-Commit-Position: refs/heads/master@{#418327}
> 
>
TBR=michaelbai@chromium.org,thakis@chromium.org,sdefresne@chromium.org,esteve...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=645716
> 
> Committed: https://crrev.com/d6c25a7f752bbfd6b485ecf0ae8036ab64317328
> Cr-Commit-Position: refs/heads/master@{#418418}

TBR=michaelbai@chromium.org,thakis@chromium.org,sdefresne@chromium.org,esteve...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=645716
==========

to

==========
Reland of Refactor the various locale_paks() templates to be more shared

Reverted by:
https://codereview.chromium.org/2340673002/

Reason for reland:
Now gn gens for enable_resource_whitelist_generation = true

Main motivation for this is to more easily add per-target
repack_whitelist.

TBR=michaelbai@chromium.org,thakis@chromium.org,sdefresne@chromium.org,esteve...
BUG=645716
==========

[agrieve, 2016-09-14 00:07:59]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2016-09-14 00:08:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 01:39:04]

Description was changed from

==========
Reland of Refactor the various locale_paks() templates to be more shared

Reverted by:
https://codereview.chromium.org/2340673002/

Reason for reland:
Now gn gens for enable_resource_whitelist_generation = true

Main motivation for this is to more easily add per-target
repack_whitelist.

TBR=michaelbai@chromium.org,thakis@chromium.org,sdefresne@chromium.org,esteve...
BUG=645716
==========

to

==========
Reland of Refactor the various locale_paks() templates to be more shared

Reverted by:
https://codereview.chromium.org/2340673002/

Reason for reland:
Now gn gens for enable_resource_whitelist_generation = true

Main motivation for this is to more easily add per-target
repack_whitelist.

TBR=michaelbai@chromium.org,thakis@chromium.org,sdefresne@chromium.org,esteve...
BUG=645716
==========

[commit-bot: I haz the power, 2016-09-14 01:39:05]

Committed patchset #2 (id:260001)

[commit-bot: I haz the power, 2016-09-14 01:42:35]

Description was changed from

==========
Reland of Refactor the various locale_paks() templates to be more shared

Reverted by:
https://codereview.chromium.org/2340673002/

Reason for reland:
Now gn gens for enable_resource_whitelist_generation = true

Main motivation for this is to more easily add per-target
repack_whitelist.

TBR=michaelbai@chromium.org,thakis@chromium.org,sdefresne@chromium.org,esteve...
BUG=645716
==========

to

==========
Reland of Refactor the various locale_paks() templates to be more shared

Reverted by:
https://codereview.chromium.org/2340673002/

Reason for reland:
Now gn gens for enable_resource_whitelist_generation = true

Main motivation for this is to more easily add per-target
repack_whitelist.

TBR=michaelbai@chromium.org,thakis@chromium.org,sdefresne@chromium.org,esteve...
BUG=645716

Committed: https://crrev.com/d83512c644c7c61331a32c97ba549fcb1d8793cb
Cr-Commit-Position: refs/heads/master@{#418450}
==========

[commit-bot: I haz the power, 2016-09-14 01:42:36]

Patchset 2 (id:??) landed as
https://crrev.com/d83512c644c7c61331a32c97ba549fcb1d8793cb
Cr-Commit-Position: refs/heads/master@{#418450}

[sdefresne, 2016-09-14 08:02:53]

https://codereview.chromium.org/2339783002/diff/260001/ios/chrome/extension_r...
File ios/chrome/extension_repack.gni (left):

https://codereview.chromium.org/2339783002/diff/260001/ios/chrome/extension_r...
ios/chrome/extension_repack.gni:52: output =
"$target_gen_dir/${invoker.output_locale}.lproj/locale.pak"
This change is breaking our downstream bots with the following failure:

The file:
  //out/Debug-iphoneos/gen/ios/chrome/share_extension/ar.lproj/locale.pak
is listed as an input or source for the target:
  //ios_internal/chrome/share_extension:system_strings_generate
but no targets in the build generate that file.

[sdefresne, 2016-09-14 08:05:43]

A revert of this CL (patchset #2 id:260001) has been created in
https://codereview.chromium.org/2338213002/ by sdefresne@chromium.org.

The reason for reverting is: The refactoring of the ios file is likely incorrect
as it breaks the autoroller (as some files are no longer generated or have
different name).

Reverting as half of the touched files are in ios/..