Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2338213002: Revert of 🍵 Refactor the various locale_paks() templates to be more shared (Closed)

Created:
4 years, 3 months ago by sdefresne
Modified:
4 years, 3 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org, android-webview-reviews_chromium.org, sdefresne+watch_chromium.org, brettw
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of 🍵 Refactor the various locale_paks() templates to be more shared (patchset #2 id:260001 of https://codereview.chromium.org/2339783002/ ) Reason for revert: The refactoring of the ios file is likely incorrect as it breaks the autoroller (as some files are no longer generated or have different name). Reverting as half of the touched files are in ios/. Original issue's description: > Reland of Refactor the various locale_paks() templates to be more shared > > Reverted by: > https://codereview.chromium.org/2340673002/ > > Reason for reland: > Now gn gens for enable_resource_whitelist_generation = true > > Main motivation for this is to more easily add per-target > repack_whitelist. > > TBR=michaelbai@chromium.org,thakis@chromium.org,sdefresne@chromium.org,estevenson@chromium.org,rsesek@chromium.org,brettw@chromium.org > BUG=645716 > > Committed: https://crrev.com/d83512c644c7c61331a32c97ba549fcb1d8793cb > Cr-Commit-Position: refs/heads/master@{#418450} TBR=michaelbai@chromium.org,thakis@chromium.org,estevenson@chromium.org,rsesek@chromium.org,brettw@chromium.org,agrieve@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=645716 Committed: https://crrev.com/cd0027d5a92461f53beee6becf61aeef85841f45 Cr-Commit-Position: refs/heads/master@{#418511}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+552 lines, -238 lines) Patch
M android_webview/webview_repack_locales.gni View 1 chunk +89 lines, -11 lines 0 comments Download
M android_webview/webview_repack_locales_list.gni View 1 chunk +1 line, -1 line 0 comments Download
M chrome/BUILD.gn View 4 chunks +2 lines, -16 lines 0 comments Download
M chrome/android/monochrome_repack_locales.gni View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_repack_locales.gni View 5 chunks +150 lines, -51 lines 0 comments Download
M ios/chrome/app/resources/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/app/resources/ios_chrome_repack.gni View 4 chunks +143 lines, -17 lines 0 comments Download
M ios/chrome/extension_repack.gni View 1 chunk +107 lines, -9 lines 0 comments Download
M ios/chrome/share_extension/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/today_extension/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ios/web/test/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/grit/repack.gni View 3 chunks +54 lines, -127 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
sdefresne
Created Revert of 🍵 Refactor the various locale_paks() templates to be more shared
4 years, 3 months ago (2016-09-14 08:05:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2338213002/1
4 years, 3 months ago (2016-09-14 08:05:54 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-14 08:06:49 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 08:09:16 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cd0027d5a92461f53beee6becf61aeef85841f45
Cr-Commit-Position: refs/heads/master@{#418511}

Powered by Google App Engine
This is Rietveld 408576698