Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Side by Side Diff: chrome/BUILD.gn

Issue 2339783002: Reland of 🍵 Refactor the various locale_paks() templates to be more shared (Closed)
Patch Set: deps += -> deps = Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/buildflag_header.gni") 5 import("//build/buildflag_header.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/compiler/compiler.gni") 7 import("//build/config/compiler/compiler.gni")
8 import("//build/config/features.gni") 8 import("//build/config/features.gni")
9 import("//build/config/locales.gni") 9 import("//build/config/locales.gni")
10 import("//build/config/sanitizers/sanitizers.gni") 10 import("//build/config/sanitizers/sanitizers.gni")
(...skipping 1435 matching lines...) Expand 10 before | Expand all | Expand 10 after
1446 } 1446 }
1447 1447
1448 if (is_mac) { 1448 if (is_mac) {
1449 output = "$root_gen_dir/repack/resources.pak" 1449 output = "$root_gen_dir/repack/resources.pak"
1450 } else { 1450 } else {
1451 output = "$root_out_dir/resources.pak" 1451 output = "$root_out_dir/resources.pak"
1452 } 1452 }
1453 1453
1454 if (enable_resource_whitelist_generation) { 1454 if (enable_resource_whitelist_generation) {
1455 repack_whitelist = android_resource_whitelist 1455 repack_whitelist = android_resource_whitelist
1456 deps += [ "//chrome:resource_whitelist" ] 1456 deps += [ ":resource_whitelist" ]
1457 } 1457 }
1458 } 1458 }
1459 1459
1460 # GYP version: chrome/chrome_resources.gyp:browser_tests_pak 1460 # GYP version: chrome/chrome_resources.gyp:browser_tests_pak
1461 repack("browser_tests_pak") { 1461 repack("browser_tests_pak") {
1462 sources = [ 1462 sources = [
1463 "$root_gen_dir/chrome/options_test_resources.pak", 1463 "$root_gen_dir/chrome/options_test_resources.pak",
1464 "$root_gen_dir/chrome/webui_test_resources.pak", 1464 "$root_gen_dir/chrome/webui_test_resources.pak",
1465 ] 1465 ]
1466 output = "$root_out_dir/browser_tests.pak" 1466 output = "$root_out_dir/browser_tests.pak"
1467 deps = [ 1467 deps = [
1468 "//chrome/browser/resources:options_test_resources", 1468 "//chrome/browser/resources:options_test_resources",
1469 "//chrome/test/data:webui_test_resources", 1469 "//chrome/test/data:webui_test_resources",
1470 ] 1470 ]
1471 } 1471 }
1472 1472
1473 # Collects per-locale grit files from many sources into global per-locale files. 1473 # Collects per-locale grit files from many sources into global per-locale files.
1474 chrome_repack_locales("repack_locales_pack") { 1474 chrome_repack_locales("repack_locales_pack") {
1475 visibility = [ ":*" ] 1475 visibility = [ ":*" ]
1476 1476
1477 input_locales = locales 1477 input_locales = locales
1478 1478
1479 if (is_mac) { 1479 if (is_mac) {
1480 output_locales = locales_as_mac_outputs 1480 output_locales = locales_as_mac_outputs
1481 } else { 1481 } else {
1482 output_locales = locales 1482 output_locales = locales
1483 } 1483 }
1484
1485 if (enable_resource_whitelist_generation) {
1486 repack_whitelist = android_resource_whitelist
1487 deps = [
1488 ":resource_whitelist",
1489 ]
1490 }
1484 } 1491 }
1485 1492
1486 chrome_repack_locales("repack_pseudo_locales_pack") { 1493 chrome_repack_locales("repack_pseudo_locales_pack") {
1487 visibility = [ ":*" ] 1494 visibility = [ ":*" ]
1488 1495
1489 input_locales = [ "fake-bidi" ] 1496 input_locales = [ "fake-bidi" ]
1490 1497
1491 if (is_mac) { 1498 if (is_mac) {
1492 output_locales = [ "fake_bidi" ] # Mac uses underscores. 1499 output_locales = [ "fake_bidi" ] # Mac uses underscores.
1493 } else { 1500 } else {
1494 output_locales = [ "fake-bidi" ] 1501 output_locales = [ "fake-bidi" ]
1495 } 1502 }
1503
1504 if (enable_resource_whitelist_generation) {
1505 repack_whitelist = android_resource_whitelist
1506 deps = [
1507 ":resource_whitelist",
1508 ]
1509 }
1496 } 1510 }
1497 1511
1498 # Generates a rule to repack a set of resources, substituting a given string 1512 # Generates a rule to repack a set of resources, substituting a given string
1499 # in for the percentage (e.g. "100", "200"). It generates the repacked files in 1513 # in for the percentage (e.g. "100", "200"). It generates the repacked files in
1500 # the "gen" directory, and then introduces a copy rule to copy it to the root 1514 # the "gen" directory, and then introduces a copy rule to copy it to the root
1501 # build directory. 1515 # build directory.
1502 # 1516 #
1503 # It's not clear why this two-step dance is necessary as opposed to just 1517 # It's not clear why this two-step dance is necessary as opposed to just
1504 # generating the file in the destination. However, this is what the GYP build 1518 # generating the file in the destination. However, this is what the GYP build
1505 # does, and for maintenance purposes, this keeps the same files in the same 1519 # does, and for maintenance purposes, this keeps the same files in the same
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
1559 } 1573 }
1560 if (enable_app_list) { 1574 if (enable_app_list) {
1561 sources += [ "$root_gen_dir/ui/app_list/resources/app_list_resources_${per cent}_percent.pak" ] 1575 sources += [ "$root_gen_dir/ui/app_list/resources/app_list_resources_${per cent}_percent.pak" ]
1562 deps += [ "//ui/app_list/resources" ] 1576 deps += [ "//ui/app_list/resources" ]
1563 } 1577 }
1564 1578
1565 output = repack_output_file 1579 output = repack_output_file
1566 1580
1567 if (enable_resource_whitelist_generation) { 1581 if (enable_resource_whitelist_generation) {
1568 repack_whitelist = android_resource_whitelist 1582 repack_whitelist = android_resource_whitelist
1569 deps += [ "//chrome:resource_whitelist" ] 1583 deps += [ ":resource_whitelist" ]
1570 } 1584 }
1571 } 1585 }
1572 1586
1573 copy(copy_name) { 1587 copy(copy_name) {
1574 visibility = [ ":*" ] 1588 visibility = [ ":*" ]
1575 deps = [ 1589 deps = [
1576 ":$repack_name", 1590 ":$repack_name",
1577 ] 1591 ]
1578 sources = [ 1592 sources = [
1579 repack_output_file, 1593 repack_output_file,
(...skipping 205 matching lines...) Expand 10 before | Expand all | Expand 10 after
1785 "//chrome/app/theme/$branding_path_component/product_logo_48.png", 1799 "//chrome/app/theme/$branding_path_component/product_logo_48.png",
1786 "//chrome/tools/build/linux/chrome-wrapper", 1800 "//chrome/tools/build/linux/chrome-wrapper",
1787 "//third_party/xdg-utils/scripts/xdg-mime", 1801 "//third_party/xdg-utils/scripts/xdg-mime",
1788 "//third_party/xdg-utils/scripts/xdg-settings", 1802 "//third_party/xdg-utils/scripts/xdg-settings",
1789 ] 1803 ]
1790 outputs = [ 1804 outputs = [
1791 "$root_out_dir/{{source_file_part}}", 1805 "$root_out_dir/{{source_file_part}}",
1792 ] 1806 ]
1793 } 1807 }
1794 } 1808 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698