Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 2340673002: Revert of 🍵 Refactor the various locale_paks() templates to be more shared (Closed)

Created:
4 years, 3 months ago by agrieve
Modified:
4 years, 3 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org, android-webview-reviews_chromium.org, sdefresne+watch_chromium.org, brettw
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of 🍵 Refactor the various locale_paks() templates to be more shared (patchset #7 id:120001 of https://codereview.chromium.org/2320883006/ ) Reason for revert: gn gen fails when enable_resource_whitelist_generation=true Original issue's description: > Refactor the various locale_paks() templates to be more shared > > Main motivation for this is to more easily add per-target > repack_whitelist. > > BUG=645716 > > Committed: https://crrev.com/61973f5b2e2d7cf070c89043768b4a3e0025b19a > Cr-Commit-Position: refs/heads/master@{#418327} TBR=michaelbai@chromium.org,thakis@chromium.org,sdefresne@chromium.org,estevenson@chromium.org,rsesek@chromium.org,brettw@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=645716 Committed: https://crrev.com/d6c25a7f752bbfd6b485ecf0ae8036ab64317328 Cr-Commit-Position: refs/heads/master@{#418418}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+550 lines, -232 lines) Patch
M android_webview/webview_repack_locales.gni View 1 chunk +89 lines, -11 lines 0 comments Download
M android_webview/webview_repack_locales_list.gni View 1 chunk +1 line, -1 line 0 comments Download
M chrome/BUILD.gn View 2 chunks +0 lines, -10 lines 0 comments Download
M chrome/android/monochrome_repack_locales.gni View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_repack_locales.gni View 5 chunks +150 lines, -51 lines 0 comments Download
M ios/chrome/app/resources/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/app/resources/ios_chrome_repack.gni View 4 chunks +143 lines, -17 lines 0 comments Download
M ios/chrome/extension_repack.gni View 1 chunk +107 lines, -9 lines 0 comments Download
M ios/chrome/share_extension/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/today_extension/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ios/web/test/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/grit/repack.gni View 3 chunks +54 lines, -127 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
agrieve
Created Revert of 🍵 Refactor the various locale_paks() templates to be more shared
4 years, 3 months ago (2016-09-13 23:45:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2340673002/1
4 years, 3 months ago (2016-09-13 23:46:13 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-13 23:47:09 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d6c25a7f752bbfd6b485ecf0ae8036ab64317328 Cr-Commit-Position: refs/heads/master@{#418418}
4 years, 3 months ago (2016-09-13 23:49:08 UTC) #6
agrieve
4 years, 3 months ago (2016-09-14 00:02:05 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2339783002/ by agrieve@chromium.org.

The reason for reverting is: Will update when fixed.

Powered by Google App Engine
This is Rietveld 408576698