Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1073)

Issue 2338373004: Refactor PropertyTreeState as GeometryPropertyTreeState (Closed)

Created:
4 years, 3 months ago by pdr.
Modified:
4 years, 3 months ago
Reviewers:
chrishtr, trchen
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-paint_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, slimming-paint-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor PropertyTreeState as GeometryPropertyTreeState The PropertyTreeState does not include scroll information and should be renamed GeometryPropertyTreeState to reflect the real behavior. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/80353fce6b36bf86ebb564584e622bc1c37ae332 Cr-Commit-Position: refs/heads/master@{#418736}

Patch Set 1 #

Patch Set 2 : Minor cleanup and forgotten loose ends #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+187 lines, -322 lines) Patch
M third_party/WebKit/Source/core/paint/ObjectPaintProperties.h View 1 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ObjectPaintProperties.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintInvalidator.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp View 12 chunks +34 lines, -34 lines 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 3 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.h View 6 chunks +25 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.cpp View 11 chunks +20 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/GeometryMapperTest.cpp View 15 chunks +58 lines, -58 lines 0 comments Download
A + third_party/WebKit/Source/platform/graphics/paint/GeometryPropertyTreeState.h View 3 chunks +8 lines, -10 lines 0 comments Download
A + third_party/WebKit/Source/platform/graphics/paint/GeometryPropertyTreeStateTest.cpp View 3 chunks +14 lines, -14 lines 0 comments Download
D third_party/WebKit/Source/platform/graphics/paint/PropertyTreeState.h View 1 chunk +0 lines, -75 lines 0 comments Download
D third_party/WebKit/Source/platform/graphics/paint/PropertyTreeStateTest.cpp View 1 chunk +0 lines, -58 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/README.md View 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
pdr.
4 years, 3 months ago (2016-09-14 20:16:38 UTC) #5
chrishtr
lgtm
4 years, 3 months ago (2016-09-14 20:35:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2338373004/40001
4 years, 3 months ago (2016-09-14 22:13:25 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-15 01:09:15 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 01:12:26 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/80353fce6b36bf86ebb564584e622bc1c37ae332
Cr-Commit-Position: refs/heads/master@{#418736}

Powered by Google App Engine
This is Rietveld 408576698