third_party/WebKit/Source/core/paint/PaintInvalidator.cpp - Issue 2338373004: Refactor PropertyTreeState as GeometryPropertyTreeState

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PaintInvalidator.cpp

Issue 2338373004: Refactor PropertyTreeState as GeometryPropertyTreeState (Closed)

Patch Set: Rebase Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/paint/ObjectPaintProperties.cpp ('k') | third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/PaintInvalidator.cpp

diff --git a/third_party/WebKit/Source/core/paint/PaintInvalidator.cpp b/third_party/WebKit/Source/core/paint/PaintInvalidator.cpp

index d30a142cd29bc6525cb085b8b325e6d151538602..3ac9f5b96bcba3815dd229c26b78ee51a07e5eb5 100644

--- a/third_party/WebKit/Source/core/paint/PaintInvalidator.cpp

+++ b/third_party/WebKit/Source/core/paint/PaintInvalidator.cpp

@@ -46,8 +46,8 @@ static LayoutRect mapLocalRectToPaintInvalidationBacking(GeometryMapper& geometr

} else if (object == context.paintInvalidationContainer) {

result = LayoutRect(rect);

} else {

- PropertyTreeState currentTreeState(context.treeBuilderContext.current.transform, context.treeBuilderContext.current.clip, context.treeBuilderContext.currentEffect);

- PropertyTreeState containerTreeState;

+ GeometryPropertyTreeState currentTreeState(context.treeBuilderContext.current.transform, context.treeBuilderContext.current.clip, context.treeBuilderContext.currentEffect);

+ GeometryPropertyTreeState containerTreeState;

const ObjectPaintProperties* containerPaintProperties = context.paintInvalidationContainer->objectPaintProperties();

containerPaintProperties->getContentsProperties(containerTreeState);

@@ -92,8 +92,8 @@ LayoutPoint PaintInvalidator::computeLocationFromPaintInvalidationBacking(const

point.moveBy(FloatPoint(context.treeBuilderContext.current.paintOffset));

bool success = false;

- PropertyTreeState currentTreeState(context.treeBuilderContext.current.transform, context.treeBuilderContext.current.clip, context.treeBuilderContext.currentEffect);

- PropertyTreeState containerTreeState;

+ GeometryPropertyTreeState currentTreeState(context.treeBuilderContext.current.transform, context.treeBuilderContext.current.clip, context.treeBuilderContext.currentEffect);

+ GeometryPropertyTreeState containerTreeState;

context.paintInvalidationContainer->objectPaintProperties()->getContentsProperties(containerTreeState);

point = m_geometryMapper.mapRectToDestinationSpace(FloatRect(point, FloatSize()), currentTreeState, containerTreeState, success).location();

DCHECK(success);