Push CompositorFilterOperations creation out of GraphicsLayer

Push CompositorFilterOperations creation out of GraphicsLayer

Push knowledge of FilterOperations out of GraphicsLayer and into
PaintLayer. This eliminates one dependency from platform/ code to the
FilterOperations structure. The motivation is to try and make
FilterOperation(s) a core (style) type, to make interaction with the
style system and other parts of core easier. It will also aid in
enabling a more layered structure on the various filter-related data
structures.

Also change the various generator functions to return a
CompositorFilterOperations by-value rather than through a out-variable.

BUG=439970
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/770c5f8e60b3a60fef60a2b815b0ac761574c46c
Cr-Commit-Position: refs/heads/master@{#419029}

[fs, 2016-09-13 16:33:56]

Description was changed from

==========
Push CompositorFilterOperations creation out of GraphicsLayer

Push knowledge of FilterOperations out of GraphicsLayer and into
PaintLayer. This eliminates one dependency from platform/ code to the
FilterOperations structure. The motivation is to try and make
FilterOperation(s) a core (style) type, to make interaction with the
style system and other parts of core easier. It will also aid in
enabling a more layered structure on the various filter-related data
structures.

Also change the various generator functions to return a
CompositorFilterOperations by-value rather than through a out-variable.

BUG=439970
==========

to

==========
Push CompositorFilterOperations creation out of GraphicsLayer

Push knowledge of FilterOperations out of GraphicsLayer and into
PaintLayer. This eliminates one dependency from platform/ code to the
FilterOperations structure. The motivation is to try and make
FilterOperation(s) a core (style) type, to make interaction with the
style system and other parts of core easier. It will also aid in
enabling a more layered structure on the various filter-related data
structures.

Also change the various generator functions to return a
CompositorFilterOperations by-value rather than through a out-variable.

BUG=439970
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[fs, 2016-09-13 16:34:02]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 16:34:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 16:52:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 16:52:23]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[fs, 2016-09-13 18:44:02]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 18:44:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 20:23:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 20:23:43]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[fs, 2016-09-13 21:58:47]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 21:59:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 23:36:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 23:36:04]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[fs, 2016-09-14 12:10:05]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 12:10:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 13:24:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 13:24:23]

Dry run: This issue passed the CQ dry run.

[fs, 2016-09-14 13:38:19]

fs@opera.com changed reviewers:
+ chrishtr@chromium.org

[pdr., 2016-09-14 17:38:27]

pdr@chromium.org changed reviewers:
+ senorblanco@chromium.org

[fs, 2016-09-15 20:20:12]

On 2016/09/14 at 13:38:20, fs wrote:
> 

Ping.

[chrishtr, 2016-09-15 20:20:36]

looking, sorry for the delay.

[chrishtr, 2016-09-15 20:29:59]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-09-15 20:30:00]

lgtm

[commit-bot: I haz the power, 2016-09-15 20:30:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 23:09:02]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-15 23:11:40]

Description was changed from

==========
Push CompositorFilterOperations creation out of GraphicsLayer

Push knowledge of FilterOperations out of GraphicsLayer and into
PaintLayer. This eliminates one dependency from platform/ code to the
FilterOperations structure. The motivation is to try and make
FilterOperation(s) a core (style) type, to make interaction with the
style system and other parts of core easier. It will also aid in
enabling a more layered structure on the various filter-related data
structures.

Also change the various generator functions to return a
CompositorFilterOperations by-value rather than through a out-variable.

BUG=439970
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Push CompositorFilterOperations creation out of GraphicsLayer

Push knowledge of FilterOperations out of GraphicsLayer and into
PaintLayer. This eliminates one dependency from platform/ code to the
FilterOperations structure. The motivation is to try and make
FilterOperation(s) a core (style) type, to make interaction with the
style system and other parts of core easier. It will also aid in
enabling a more layered structure on the various filter-related data
structures.

Also change the various generator functions to return a
CompositorFilterOperations by-value rather than through a out-variable.

BUG=439970
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/770c5f8e60b3a60fef60a2b815b0ac761574c46c
Cr-Commit-Position: refs/heads/master@{#419029}
==========

[commit-bot: I haz the power, 2016-09-15 23:11:41]

Patchset 4 (id:??) landed as
https://crrev.com/770c5f8e60b3a60fef60a2b815b0ac761574c46c
Cr-Commit-Position: refs/heads/master@{#419029}

[Stephen White, 2016-09-16 14:05:59]

Post-landing LGTM.

https://codereview.chromium.org/2335253002/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.h
(right):

https://codereview.chromium.org/2335253002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.h:46:
PLATFORM_EXPORT CompositorFilterOperations buildFilterOperations(const
FilterOperations&);
Does this mean we'll be incurring the copy constructor of
CompositorFilterOperations, and transitively, cc::FilterOperations and
std::vector<FilterOperation>? The only move constructor for cc::FilterOperations
I could find takes a std::vector<FilterOperation>&&, not a
cc::FilterOperations&&, but maybe I'm reading things incorrectly.

[fs, 2016-09-16 14:54:38]

https://codereview.chromium.org/2335253002/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.h
(right):

https://codereview.chromium.org/2335253002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.h:46:
PLATFORM_EXPORT CompositorFilterOperations buildFilterOperations(const
FilterOperations&);
On 2016/09/16 at 14:05:59, Stephen White wrote:
> Does this mean we'll be incurring the copy constructor of
CompositorFilterOperations, and transitively, cc::FilterOperations and
std::vector<FilterOperation>? The only move constructor for cc::FilterOperations
I could find takes a std::vector<FilterOperation>&&, not a
cc::FilterOperations&&, but maybe I'm reading things incorrectly.

I could be wrong, but I think this would RVO. Empirical testing (==reading the
generated code) suggests there's no undue copying going on (that didn't go on
before this CL.)