third_party/WebKit/Source/platform/animation/AnimationTranslationUtilTest.cpp - Issue 2335253002: Push CompositorFilterOperations creation out of GraphicsLayer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/animation/AnimationTranslationUtilTest.cpp

Issue 2335253002: Push CompositorFilterOperations creation out of GraphicsLayer (Closed)

Patch Set: The right FilterOperations Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/animation/AnimationTranslationUtil.cpp ('k') | third_party/WebKit/Source/platform/graphics/GraphicsLayer.h » ('j') | third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/animation/AnimationTranslationUtilTest.cpp

diff --git a/third_party/WebKit/Source/platform/animation/AnimationTranslationUtilTest.cpp b/third_party/WebKit/Source/platform/animation/AnimationTranslationUtilTest.cpp

index 82dfc7ce235f8e06c5c9ff19361e333de60851ef..65521185ab337bbadedcd9577fb01d987f5f8d20 100644

--- a/third_party/WebKit/Source/platform/animation/AnimationTranslationUtilTest.cpp

+++ b/third_party/WebKit/Source/platform/animation/AnimationTranslationUtilTest.cpp

@@ -74,13 +74,12 @@ TEST(AnimationTranslationUtilTest, transformsWork)

TEST(AnimationTranslationUtilTest, filtersWork)

{

FilterOperations ops;

- CompositorFilterOperations outOps;

ops.operations().append(BasicColorMatrixFilterOperation::create(0.5, FilterOperation::SATURATE));

ops.operations().append(BasicColorMatrixFilterOperation::create(0.2, FilterOperation::GRAYSCALE));

ops.operations().append(BasicColorMatrixFilterOperation::create(0.8, FilterOperation::SEPIA));

ops.operations().append(BasicComponentTransferFilterOperation::create(0.1, FilterOperation::OPACITY));

- toCompositorFilterOperations(ops, &outOps);

+ CompositorFilterOperations outOps = toCompositorFilterOperations(ops);

EXPECT_EQ(4UL, outOps.asCcFilterOperations().size());

const float err = 0.0001;