third_party/WebKit/Source/core/paint/FilterPainter.cpp - Issue 2335253002: Push CompositorFilterOperations creation out of GraphicsLayer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/FilterPainter.cpp

Issue 2335253002: Push CompositorFilterOperations creation out of GraphicsLayer (Closed)

Patch Set: The right FilterOperations Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp ('k') | third_party/WebKit/Source/core/paint/PaintLayer.h » ('j') | third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/FilterPainter.cpp

diff --git a/third_party/WebKit/Source/core/paint/FilterPainter.cpp b/third_party/WebKit/Source/core/paint/FilterPainter.cpp

index 49b87199cc90c0b289c9e0fd3f1e4c7e89a529ef..a1a0bebd50528c1e60c24854f24a9590f5ce7aab 100644

--- a/third_party/WebKit/Source/core/paint/FilterPainter.cpp

+++ b/third_party/WebKit/Source/core/paint/FilterPainter.cpp

@@ -52,9 +52,7 @@ FilterPainter::FilterPainter(PaintLayer& layer, GraphicsContext& context, const

m_clipRecorder = wrapUnique(new LayerClipRecorder(context, *layer.layoutObject(), DisplayItem::kClipLayerFilter, clipRect, &paintingInfo, LayoutPoint(), paintFlags));

if (!context.getPaintController().displayItemConstructionIsDisabled()) {

- FilterOperations filterOperations(layer.computeFilterOperations(m_layoutObject->styleRef()));

- CompositorFilterOperations compositorFilterOperations;

- SkiaImageFilterBuilder::buildFilterOperations(filterOperations, &compositorFilterOperations);

+ CompositorFilterOperations compositorFilterOperations = layer.createCompositorFilterOperationsForFilter(m_layoutObject->styleRef());

// FIXME: It's possible to have empty CompositorFilterOperations here even

// though the SkImageFilter produced above is non-null, since the

// layer's FilterEffectBuilder can have a stale representation of