Push CompositorFilterOperations creation out of GraphicsLayer

third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.h

Index: third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.h
diff --git a/third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.h b/third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.h
index ba4b88ce806c3895c77b19749bcbdde42680e59f..8f4f94e8d376602a0bb2342b3fc5ae25c2ead900 100644
--- a/third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.h
+++ b/third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.h
@@ -35,18 +35,15 @@ class SkPicture;
 
 namespace blink {
 
-class AffineTransform;
 class BoxReflection;
 class CompositorFilterOperations;
 class FilterEffect;
 class FilterOperations;
-class Image;
 
 namespace SkiaImageFilterBuilder {
 
 PLATFORM_EXPORT sk_sp<SkImageFilter> build(FilterEffect*, ColorSpace, bool requiresPMColorValidation = true);
-PLATFORM_EXPORT void buildFilterOperations(const FilterOperations&, CompositorFilterOperations*);
-PLATFORM_EXPORT sk_sp<SkImageFilter> buildTransform(const AffineTransform&, sk_sp<SkImageFilter> input);
+PLATFORM_EXPORT CompositorFilterOperations buildFilterOperations(const FilterOperations&);

[Stephen White, 2016/09/16 14:05:59]

Does this mean we'll be incurring the copy constructor of
CompositorFilterOperations, and transitively, cc::FilterOperations and
std::vector<FilterOperation>? The only move constructor for cc::FilterOperations
I could find takes a std::vector<FilterOperation>&&, not a
cc::FilterOperations&&, but maybe I'm reading things incorrectly.

[fs, 2016/09/16 14:54:38]

I could be wrong, but I think this would RVO. Empirical testing (==reading the
generated code) suggests there's no undue copying going on (that didn't go on
before this CL.)

 
 PLATFORM_EXPORT sk_sp<SkImageFilter> transformColorSpace(
     sk_sp<SkImageFilter> input, ColorSpace srcColorSpace, ColorSpace dstColorSpace);