Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1029)

Unified Diff: third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp

Issue 2335253002: Push CompositorFilterOperations creation out of GraphicsLayer (Closed)
Patch Set: The right FilterOperations Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp
diff --git a/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp b/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp
index 3437cf4296e70ae3d4d4bbdf1ffbe584cd95c7a5..7e3d2ba17bbc5e47f4600dde44ee511880c045b0 100644
--- a/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp
+++ b/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp
@@ -40,7 +40,6 @@
#include "platform/graphics/GraphicsContext.h"
#include "platform/graphics/Image.h"
#include "platform/graphics/LinkHighlight.h"
-#include "platform/graphics/filters/SkiaImageFilterBuilder.h"
#include "platform/graphics/paint/DrawingRecorder.h"
#include "platform/graphics/paint/PaintController.h"
#include "platform/json/JSONValues.h"
@@ -1145,18 +1144,14 @@ WebLayer* GraphicsLayer::platformLayer() const
return m_layer->layer();
}
-void GraphicsLayer::setFilters(const FilterOperations& filters)
+void GraphicsLayer::setFilters(CompositorFilterOperations filters)
{
- CompositorFilterOperations compositorFilters;
- SkiaImageFilterBuilder::buildFilterOperations(filters, &compositorFilters);
- m_layer->layer()->setFilters(compositorFilters.releaseCcFilterOperations());
+ platformLayer()->setFilters(filters.releaseCcFilterOperations());
}
-void GraphicsLayer::setBackdropFilters(const FilterOperations& filters)
+void GraphicsLayer::setBackdropFilters(CompositorFilterOperations filters)
{
- CompositorFilterOperations compositorFilters;
- SkiaImageFilterBuilder::buildFilterOperations(filters, &compositorFilters);
- m_layer->layer()->setBackgroundFilters(compositorFilters.releaseCcFilterOperations());
+ platformLayer()->setBackgroundFilters(filters.releaseCcFilterOperations());
}
void GraphicsLayer::setFilterQuality(SkFilterQuality filterQuality)

Powered by Google App Engine
This is Rietveld 408576698