Issue 23243003: [oilpan] Wrap NodeVector into CollectionRoot for ensure that contained nodes stay alive.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23243003: [oilpan] Wrap NodeVector into CollectionRoot for ensure that contained nodes stay alive. (Closed)

Created:
7 years, 4 months ago by Vyacheslav Egorov (Google)

Modified:
7 years, 4 months ago

Reviewers:
haraken, Mads Ager (chromium)

CC:
blink-reviews, adamk+oilpan_chromium.org, Mads Ager (chromium), abarth-chromium

Base URL:
svn://svn.chromium.org/blink/branches/oilpan

Visibility:
Public.

More Reviews

Description

[oilpan] Wrap NodeVector into CollectionRoot for ensure that contained nodes stay alive. This fixes bug instroduced in r156083: NodeVector used to contain RefPtr<Node> but was converted to contain Member<Node> without additional CollectionRoot<> wrapping. Additionally it tweaks CollectionRoot<T> to provide iterator/const_iterator types from the underlying Collection and redirect operator[] to further minimize amount of changes that needs to be done when wrapping something in CollectionRoot. R=ager@chromium.org BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156236

Patch Set 1 #

Patch Set 2 : Fix infinite looping #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -22 lines)			Patch
M	Source/core/dom/ContainerNode.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	Source/core/dom/ContainerNode.cpp	View		11 chunks	+14 lines, -14 lines	0 comments	Download
M	Source/core/editing/ApplyStyleCommand.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/editing/ReplaceNodeWithSpanCommand.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/html/HTMLMediaElement.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/heap/Handle.h	View	1	1 chunk	+16 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Google)

Committed patchset #2 manually as r156236 (presubmit successful).

7 years, 4 months ago (2013-08-16 19:07:30 UTC) #3

haraken

7 years, 4 months ago (2013-08-17 00:33:39 UTC) #4

Message was sent while issue was closed.

LGTM. I hope Erik's verification mechanism will auto-catch this kind of Member
mis-visiting :)

Expand Messages | Collapse Messages