Source/core/editing/ReplaceNodeWithSpanCommand.cpp - Issue 23243003: [oilpan] Wrap NodeVector into CollectionRoot for ensure that contained nodes stay alive.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/ReplaceNodeWithSpanCommand.cpp

Issue 23243003: [oilpan] Wrap NodeVector into CollectionRoot for ensure that contained nodes stay alive. (Closed) Base URL: svn://svn.chromium.org/blink/branches/oilpan

Patch Set: Fix infinite looping Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/editing/ReplaceNodeWithSpanCommand.cpp

diff --git a/Source/core/editing/ReplaceNodeWithSpanCommand.cpp b/Source/core/editing/ReplaceNodeWithSpanCommand.cpp

index 575e4b3706616e3a3dbc4d8f1651a8762f4eeff0..3ed3f23d85c84fad2f84dae7e504a2591d1a0935 100644

--- a/Source/core/editing/ReplaceNodeWithSpanCommand.cpp

+++ b/Source/core/editing/ReplaceNodeWithSpanCommand.cpp

@@ -56,7 +56,7 @@ static void swapInNodePreservingAttributesAndChildren(const Handle<HTMLElement>&

NodeVector children;

getChildNodes(nodeToReplace.raw(), children);

- for (size_t i = 0; i < children.size(); ++i)

+ for (size_t i = 0; i < children->size(); ++i)

newNode->appendChild(children[i], ASSERT_NO_EXCEPTION);

// FIXME: Fix this to send the proper MutationRecords when MutationObservers are present.

« no previous file with comments | « Source/core/editing/ApplyStyleCommand.cpp ('k') | Source/core/html/HTMLMediaElement.cpp » ('j') | no next file with comments »