Source/core/html/HTMLMediaElement.cpp - Issue 23243003: [oilpan] Wrap NodeVector into CollectionRoot for ensure that contained nodes stay alive.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLMediaElement.cpp

Issue 23243003: [oilpan] Wrap NodeVector into CollectionRoot for ensure that contained nodes stay alive. (Closed) Base URL: svn://svn.chromium.org/blink/branches/oilpan

Patch Set: Fix infinite looping Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLMediaElement.cpp

diff --git a/Source/core/html/HTMLMediaElement.cpp b/Source/core/html/HTMLMediaElement.cpp

index d8a1a6f89cd52e7af8efa6e0e8b36e0f5d02e52d..6b0cfd530cbb92d94a88af79a1c1085ba9d72a59 100644

--- a/Source/core/html/HTMLMediaElement.cpp

+++ b/Source/core/html/HTMLMediaElement.cpp

@@ -3073,7 +3073,7 @@ KURL HTMLMediaElement::selectNextSourceChild(ContentType* contentType, String* k

NodeVector potentialSourceNodes;

getChildNodes(this, potentialSourceNodes);

- for (unsigned i = 0; !canUseSourceElement && i < potentialSourceNodes.size(); ++i) {

+ for (unsigned i = 0; !canUseSourceElement && i < potentialSourceNodes->size(); ++i) {

HandleScope scope;

node = potentialSourceNodes[i];

if (lookingForStartNode && m_nextChildNodeToConsider != node.raw())

« no previous file with comments | « Source/core/editing/ReplaceNodeWithSpanCommand.cpp ('k') | Source/heap/Handle.h » ('j') | no next file with comments »