Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(745)

Unified Diff: Source/core/dom/ContainerNode.h

Issue 23243003: [oilpan] Wrap NodeVector into CollectionRoot for ensure that contained nodes stay alive. (Closed) Base URL: svn://svn.chromium.org/blink/branches/oilpan
Patch Set: Fix infinite looping Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/dom/ContainerNode.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/ContainerNode.h
diff --git a/Source/core/dom/ContainerNode.h b/Source/core/dom/ContainerNode.h
index 2f4c1e6db68ce007f09601fd12b55476b60e8caf..cc9cbacaef804decb300f12ba772f90cd2940cb3 100644
--- a/Source/core/dom/ContainerNode.h
+++ b/Source/core/dom/ContainerNode.h
@@ -272,14 +272,14 @@ inline bool Node::needsShadowTreeWalker() const
// for a Node Vector that is used to store child Nodes of a given Node.
// FIXME: Optimize the value.
const int initialNodeVectorSize = 11;
-typedef Vector<Member<Node>, initialNodeVectorSize> NodeVector;
+typedef CollectionRoot<Vector<Member<Node>, initialNodeVectorSize> > NodeVector;
inline void getChildNodes(Node* node, NodeVector& nodes)
{
- ASSERT(!nodes.size());
+ ASSERT(!nodes->size());
for (Handle<Node> child = node->firstChild(); child; child = child->nextSibling()) {
NoHandleScope scope;
- nodes.append(child);
+ nodes->append(child);
}
}
« no previous file with comments | « no previous file | Source/core/dom/ContainerNode.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698