Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Side by Side Diff: Source/core/html/HTMLMediaElement.cpp

Issue 23243003: [oilpan] Wrap NodeVector into CollectionRoot for ensure that contained nodes stay alive. (Closed) Base URL: svn://svn.chromium.org/blink/branches/oilpan
Patch Set: Fix infinite looping Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/editing/ReplaceNodeWithSpanCommand.cpp ('k') | Source/heap/Handle.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 3055 matching lines...) Expand 10 before | Expand all | Expand 10 after
3066 Handle<HTMLSourceElement> source; 3066 Handle<HTMLSourceElement> source;
3067 String type; 3067 String type;
3068 String system; 3068 String system;
3069 bool lookingForStartNode = m_nextChildNodeToConsider; 3069 bool lookingForStartNode = m_nextChildNodeToConsider;
3070 bool canUseSourceElement = false; 3070 bool canUseSourceElement = false;
3071 bool okToLoadSourceURL; 3071 bool okToLoadSourceURL;
3072 3072
3073 NodeVector potentialSourceNodes; 3073 NodeVector potentialSourceNodes;
3074 getChildNodes(this, potentialSourceNodes); 3074 getChildNodes(this, potentialSourceNodes);
3075 3075
3076 for (unsigned i = 0; !canUseSourceElement && i < potentialSourceNodes.size() ; ++i) { 3076 for (unsigned i = 0; !canUseSourceElement && i < potentialSourceNodes->size( ); ++i) {
3077 HandleScope scope; 3077 HandleScope scope;
3078 node = potentialSourceNodes[i]; 3078 node = potentialSourceNodes[i];
3079 if (lookingForStartNode && m_nextChildNodeToConsider != node.raw()) 3079 if (lookingForStartNode && m_nextChildNodeToConsider != node.raw())
3080 continue; 3080 continue;
3081 lookingForStartNode = false; 3081 lookingForStartNode = false;
3082 3082
3083 if (!node->hasTagName(sourceTag)) 3083 if (!node->hasTagName(sourceTag))
3084 continue; 3084 continue;
3085 if (node->parentNode() != this) 3085 if (node->parentNode() != this)
3086 continue; 3086 continue;
(...skipping 1378 matching lines...) Expand 10 before | Expand all | Expand 10 after
4465 } 4465 }
4466 4466
4467 void HTMLMediaElement::accept(Visitor* visitor) const 4467 void HTMLMediaElement::accept(Visitor* visitor) const
4468 { 4468 {
4469 visitor->visit(m_currentSourceNode); 4469 visitor->visit(m_currentSourceNode);
4470 HTMLElement::accept(visitor); 4470 HTMLElement::accept(visitor);
4471 } 4471 }
4472 4472
4473 } 4473 }
4474 4474
OLDNEW
« no previous file with comments | « Source/core/editing/ReplaceNodeWithSpanCommand.cpp ('k') | Source/heap/Handle.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698