Source/core/editing/ApplyStyleCommand.cpp - Issue 23243003: [oilpan] Wrap NodeVector into CollectionRoot for ensure that contained nodes stay alive.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/ApplyStyleCommand.cpp

Issue 23243003: [oilpan] Wrap NodeVector into CollectionRoot for ensure that contained nodes stay alive. (Closed) Base URL: svn://svn.chromium.org/blink/branches/oilpan

Patch Set: Fix infinite looping Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/editing/ApplyStyleCommand.cpp

diff --git a/Source/core/editing/ApplyStyleCommand.cpp b/Source/core/editing/ApplyStyleCommand.cpp

index c09fe862d61560d57059d30632e45f5dc38ef3a5..ebd8e43e298d71635c0bcaa32094de03af706c15 100644

--- a/Source/core/editing/ApplyStyleCommand.cpp

+++ b/Source/core/editing/ApplyStyleCommand.cpp

@@ -1047,8 +1047,8 @@ void ApplyStyleCommand::pushDownInlineStyleAroundNode(EditingStyle* style, Node*

CollectionRoot<Vector<Member<Element> > > elementsToPushDown;

while (current && current != targetNode && current->contains(adoptRawResult(targetNode))) {

HandleScope scope;

- CollectionRoot<NodeVector> currentChildren;

- getChildNodes(current.raw(), *currentChildren);

+ NodeVector currentChildren;

+ getChildNodes(current.raw(), currentChildren);

Handle<StyledElement> styledElement;

if (current->isStyledElement() && isStyledInlineElementToRemove(toElement(current))) {

styledElement = Handle<StyledElement>::cast(current);

« no previous file with comments | « Source/core/dom/ContainerNode.cpp ('k') | Source/core/editing/ReplaceNodeWithSpanCommand.cpp » ('j') | no next file with comments »