Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 23185004: Rename kES2_GrGLBinding to kES_GrGLBinding. Step 0 for supporting ES3. (Closed)

Created:
7 years, 4 months ago by bsalomon
Modified:
7 years, 4 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Rename kES2_GrGLBinding to kES_GrGLBinding. Step 0 for supporting ES3. R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=10747

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -23 lines) Patch
M src/gpu/gl/GrGLCaps.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLInterface.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLSL.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLShaderBuilder.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLShaderVar.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLUtil.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGpuGL.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/gl/SkGLContextHelper.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/gl/android/GrGLCreateNativeInterface_android.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/gl/angle/GrGLCreateANGLEInterface.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/iOS/GrGLCreateNativeInterface_iOS.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
bsalomon
7 years, 4 months ago (2013-08-15 18:19:25 UTC) #1
robertphillips
lgtm
7 years, 4 months ago (2013-08-15 18:21:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/23185004/1
7 years, 4 months ago (2013-08-15 18:21:43 UTC) #3
commit-bot: I haz the power
Retried try job too often on Build-Mac10.7-Clang-x86-Release-Trybot for step(s) BuildTools http://108.170.217.252:10117/buildstatus?builder=Build-Mac10.7-Clang-x86-Release-Trybot&number=399
7 years, 4 months ago (2013-08-15 18:46:54 UTC) #4
bsalomon
7 years, 4 months ago (2013-08-15 18:55:04 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r10747.

Powered by Google App Engine
This is Rietveld 408576698