Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 231693002: Remove some dependencies on ContentView. (Closed)

Created:
6 years, 8 months ago by Yaron
Modified:
6 years, 8 months ago
Reviewers:
newt (away)
CC:
chromium-reviews, tim+watch_chromium.org, jam, benquan, haitaol+watch_chromium.org, browser-components-watch_chromium.org, darin-cc_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org, maniscalco+watch_chromium.org
Visibility:
Public.

Description

Remove some dependencies on ContentView. Turns out that https://chromiumcodereview.appspot.com/11788005 made it such that blocking for JavaScript doesn't require ContentViewClient, just a ContentViewCore. Many places in tests still get the ContentView in order to create a TestCallbackHelperContainer in order to wait for JavaScript to execute... Instead for clients that don't care about waiting themselves for JS to execute, just do it inside JavaScriptUtils. BUG=360644 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262929

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -194 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillDialogControllerTest.java View 6 chunks +32 lines, -37 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillPopupTest.java View 1 6 chunks +16 lines, -21 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectFileDialogTest.java View 4 chunks +4 lines, -7 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectPopupOtherContentViewTest.java View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/sync/SyncTest.java View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/test/ModalDialogTest.java View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/contextmenu/ContextMenuUtils.java View 1 chunk +1 line, -1 line 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/ContentDetectionTestBase.java View 2 chunks +4 lines, -4 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/ContentViewLocationTest.java View 2 chunks +2 lines, -1 line 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/ContentViewPopupZoomerTest.java View 1 chunk +1 line, -1 line 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/GestureDetectorResetTest.java View 6 chunks +8 lines, -11 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/NavigationTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/ScreenOrientationIntegrationTest.java View 3 chunks +0 lines, -3 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/TestsJavaScriptEvalTest.java View 3 chunks +1 line, -5 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/ViewportTest.java View 1 chunk +1 line, -15 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java View 5 chunks +10 lines, -10 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/input/InsertionHandleTest.java View 1 2 chunks +1 line, -3 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/input/SelectPopupTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/input/SelectionHandleTest.java View 1 2 chunks +1 line, -3 lines 0 comments Download
M content/public/test/android/javatests/src/org/chromium/content/browser/test/util/DOMUtils.java View 9 chunks +20 lines, -25 lines 0 comments Download
M content/public/test/android/javatests/src/org/chromium/content/browser/test/util/JavaScriptUtils.java View 3 chunks +6 lines, -18 lines 0 comments Download
M content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestCallbackHelperContainer.java View 2 chunks +2 lines, -6 lines 0 comments Download
M content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestContentViewClient.java View 2 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Yaron
6 years, 8 months ago (2014-04-09 20:03:41 UTC) #1
newt (away)
lgtm https://codereview.chromium.org/231693002/diff/1/content/public/android/javatests/src/org/chromium/content/browser/input/InsertionHandleTest.java File content/public/android/javatests/src/org/chromium/content/browser/input/InsertionHandleTest.java (right): https://codereview.chromium.org/231693002/diff/1/content/public/android/javatests/src/org/chromium/content/browser/input/InsertionHandleTest.java#newcode252 content/public/android/javatests/src/org/chromium/content/browser/input/InsertionHandleTest.java:252: Rect nodeBounds = DOMUtils.getNodeBounds(getContentViewCore(), fits on one line ...
6 years, 8 months ago (2014-04-09 21:30:22 UTC) #2
Yaron
The CQ bit was checked by yfriedman@chromium.org
6 years, 8 months ago (2014-04-10 00:10:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/231693002/20001
6 years, 8 months ago (2014-04-10 00:11:03 UTC) #4
Yaron
On 2014/04/10 00:10:32, Yaron wrote: > The CQ bit was checked by mailto:yfriedman@chromium.org Test failure ...
6 years, 8 months ago (2014-04-10 00:11:23 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-10 01:28:56 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_rel
6 years, 8 months ago (2014-04-10 01:28:56 UTC) #7
Yaron
The CQ bit was checked by yfriedman@chromium.org
6 years, 8 months ago (2014-04-10 01:58:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/231693002/20001
6 years, 8 months ago (2014-04-10 01:58:35 UTC) #9
commit-bot: I haz the power
6 years, 8 months ago (2014-04-10 05:20:47 UTC) #10
Message was sent while issue was closed. 
Change committed as 262929

Powered by Google App Engine
This is Rietveld 408576698