content/public/android/javatests/src/org/chromium/content/browser/input/SelectionHandleTest.java - Issue 231693002: Remove some dependencies on ContentView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/input/SelectionHandleTest.java

Issue 231693002: Remove some dependencies on ContentView. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/javatests/src/org/chromium/content/browser/input/SelectPopupTest.java ('k') | content/public/test/android/javatests/src/org/chromium/content/browser/test/util/DOMUtils.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/javatests/src/org/chromium/content/browser/input/SelectionHandleTest.java

diff --git a/content/public/android/javatests/src/org/chromium/content/browser/input/SelectionHandleTest.java b/content/public/android/javatests/src/org/chromium/content/browser/input/SelectionHandleTest.java

index 3f7ed3ecbceffe6ce475fad48c716ee3256bea57..a0adce4dacb204274179d9fda962d17425e22ffd 100644

--- a/content/public/android/javatests/src/org/chromium/content/browser/input/SelectionHandleTest.java

+++ b/content/public/android/javatests/src/org/chromium/content/browser/input/SelectionHandleTest.java

@@ -22,7 +22,6 @@ import org.chromium.content.browser.RenderCoordinates;

import org.chromium.content.browser.test.util.Criteria;

import org.chromium.content.browser.test.util.CriteriaHelper;

import org.chromium.content.browser.test.util.DOMUtils;

-import org.chromium.content.browser.test.util.TestCallbackHelperContainer;

import org.chromium.content.browser.test.util.TestInputMethodManagerWrapper;

import org.chromium.content.browser.test.util.TestTouchUtils;

import org.chromium.content.browser.test.util.TouchCommon;

@@ -449,8 +448,7 @@ public class SelectionHandleTest extends ContentShellTestBase {

}

private Rect getNodeBoundsPix(String nodeId) throws Throwable {

- Rect nodeBounds = DOMUtils.getNodeBounds(getContentViewCore(),

- new TestCallbackHelperContainer(getContentView()), nodeId);

+ Rect nodeBounds = DOMUtils.getNodeBounds(getContentViewCore(), nodeId);

RenderCoordinates renderCoordinates = getContentViewCore().getRenderCoordinates();

int offsetX = getContentViewCore().getViewportSizeOffsetWidthPix();