content/public/android/javatests/src/org/chromium/content/browser/input/SelectPopupTest.java - Issue 231693002: Remove some dependencies on ContentView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/input/SelectPopupTest.java

Issue 231693002: Remove some dependencies on ContentView. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/javatests/src/org/chromium/content/browser/input/InsertionHandleTest.java ('k') | content/public/android/javatests/src/org/chromium/content/browser/input/SelectionHandleTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/javatests/src/org/chromium/content/browser/input/SelectPopupTest.java

diff --git a/content/public/android/javatests/src/org/chromium/content/browser/input/SelectPopupTest.java b/content/public/android/javatests/src/org/chromium/content/browser/input/SelectPopupTest.java

index d7aef68129f33bd1aff51eefa486ce515b885f27..51e4a9af0709afb85efae2d0eb1c82968f8f3d7f 100644

--- a/content/public/android/javatests/src/org/chromium/content/browser/input/SelectPopupTest.java

+++ b/content/public/android/javatests/src/org/chromium/content/browser/input/SelectPopupTest.java

@@ -83,7 +83,7 @@ public class SelectPopupTest extends ContentShellTestBase {

viewClient.getOnPageFinishedHelper();

// Once clicked, the popup should show up.

- DOMUtils.clickNode(this, view, viewClient, "select");

+ DOMUtils.clickNode(this, view, "select");

assertTrue("The select popup did not show up on click.",

CriteriaHelper.pollForCriteria(new PopupShowingCriteria()));

@@ -104,7 +104,7 @@ public class SelectPopupTest extends ContentShellTestBase {

CriteriaHelper.pollForCriteria(new PopupHiddenCriteria()));

// Click the select and wait for the popup to show.

- DOMUtils.clickNode(this, view, viewClient, "select");

+ DOMUtils.clickNode(this, view, "select");

assertTrue("The select popup did not show on click after reload.",

CriteriaHelper.pollForCriteria(new PopupShowingCriteria()));

}