content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestContentViewClient.java - Issue 231693002: Remove some dependencies on ContentView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestContentViewClient.java

Issue 231693002: Remove some dependencies on ContentView. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestCallbackHelperContainer.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestContentViewClient.java

diff --git a/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestContentViewClient.java b/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestContentViewClient.java

index e014193c0f22df4e051ccd049f825d473d0e43d3..5103eac67bf6c46e745799439ca9ab152e8b83d2 100644

--- a/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestContentViewClient.java

+++ b/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestContentViewClient.java

@@ -7,7 +7,6 @@ package org.chromium.content.browser.test.util;

import android.content.Context;

import org.chromium.content.browser.ContentViewClient;

-import org.chromium.content.browser.test.util.TestCallbackHelperContainer.OnEvaluateJavaScriptResultHelper;

import org.chromium.content.browser.test.util.TestCallbackHelperContainer.OnStartContentIntentHelper;

/**

@@ -18,18 +17,12 @@ import org.chromium.content.browser.test.util.TestCallbackHelperContainer.OnStar

public class TestContentViewClient extends ContentViewClient {

- private OnEvaluateJavaScriptResultHelper mOnEvaluateJavaScriptResultHelper;

- private OnStartContentIntentHelper mOnStartContentIntentHelper;

+ private final OnStartContentIntentHelper mOnStartContentIntentHelper;

public TestContentViewClient() {

- mOnEvaluateJavaScriptResultHelper = new OnEvaluateJavaScriptResultHelper();

mOnStartContentIntentHelper = new OnStartContentIntentHelper();

}

- public OnEvaluateJavaScriptResultHelper getOnEvaluateJavaScriptResultHelper() {

- return mOnEvaluateJavaScriptResultHelper;

- }

public OnStartContentIntentHelper getOnStartContentIntentHelper() {

return mOnStartContentIntentHelper;

}