Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(797)

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java

Issue 231693002: Remove some dependencies on ContentView. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
diff --git a/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java b/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
index 8f4a90e47adaaaddeff3cb7f642713123ec94c44..bd4167dc0ece544cc81b8144123456714463ada0 100644
--- a/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
+++ b/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
@@ -72,8 +72,8 @@ public class ImeTest extends ContentShellTestBase {
// TODO(aurimas) remove this wait once crbug.com/179511 is fixed.
assertWaitForPageScaleFactorMatch(2);
assertTrue(DOMUtils.waitForNonZeroNodeBounds(
- mContentViewCore, mCallbackContainer, "input_text"));
- DOMUtils.clickNode(this, mContentView, mCallbackContainer, "input_text");
+ mContentViewCore, "input_text"));
+ DOMUtils.clickNode(this, mContentView, "input_text");
assertWaitForKeyboardStatus(true);
mConnection = (TestAdapterInputConnection) getAdapterInputConnection();
@@ -136,10 +136,10 @@ public class ImeTest extends ContentShellTestBase {
commitText(mConnection, "hello", 1);
waitAndVerifyEditableCallback(mConnection.mImeUpdateQueue, 1, "hello", 5, 5, -1, -1);
- DOMUtils.clickNode(this, mContentView, mCallbackContainer, "input_radio");
+ DOMUtils.clickNode(this, mContentView, "input_radio");
assertWaitForKeyboardStatus(false);
- DOMUtils.clickNode(this, mContentView, mCallbackContainer, "input_text");
+ DOMUtils.clickNode(this, mContentView, "input_text");
assertWaitForKeyboardStatus(true);
assertEquals(5, mInputMethodManagerWrapper.getEditorInfo().initialSelStart);
assertEquals(5, mInputMethodManagerWrapper.getEditorInfo().initialSelEnd);
@@ -207,13 +207,13 @@ public class ImeTest extends ContentShellTestBase {
@SmallTest
@Feature({"TextInput", "Main"})
public void testShowImeIfNeeded() throws Throwable {
- DOMUtils.focusNode(this, mContentViewCore, mCallbackContainer, "input_radio");
+ DOMUtils.focusNode(this, mContentViewCore, "input_radio");
assertWaitForKeyboardStatus(false);
performShowImeIfNeeded();
assertWaitForKeyboardStatus(false);
- DOMUtils.focusNode(this, mContentViewCore, mCallbackContainer, "input_text");
+ DOMUtils.focusNode(this, mContentViewCore, "input_text");
assertWaitForKeyboardStatus(false);
performShowImeIfNeeded();
@@ -224,9 +224,9 @@ public class ImeTest extends ContentShellTestBase {
@Feature({"TextInput", "Main"})
public void testFinishComposingText() throws Throwable {
// Focus the textarea. We need to do the following steps because we are focusing using JS.
- DOMUtils.focusNode(this, mContentViewCore, mCallbackContainer, "input_radio");
+ DOMUtils.focusNode(this, mContentViewCore, "input_radio");
assertWaitForKeyboardStatus(false);
- DOMUtils.focusNode(this, mContentViewCore, mCallbackContainer, "textarea");
+ DOMUtils.focusNode(this, mContentViewCore, "textarea");
assertWaitForKeyboardStatus(false);
performShowImeIfNeeded();
assertWaitForKeyboardStatus(true);
@@ -257,9 +257,9 @@ public class ImeTest extends ContentShellTestBase {
@Feature({"TextInput", "Main"})
public void testEnterKeyEventWhileComposingText() throws Throwable {
// Focus the textarea. We need to do the following steps because we are focusing using JS.
- DOMUtils.focusNode(this, mContentViewCore, mCallbackContainer, "input_radio");
+ DOMUtils.focusNode(this, mContentViewCore, "input_radio");
assertWaitForKeyboardStatus(false);
- DOMUtils.focusNode(this, mContentViewCore, mCallbackContainer, "textarea");
+ DOMUtils.focusNode(this, mContentViewCore, "textarea");
assertWaitForKeyboardStatus(false);
performShowImeIfNeeded();
assertWaitForKeyboardStatus(true);

Powered by Google App Engine
This is Rietveld 408576698