content/public/android/javatests/src/org/chromium/content/browser/ContentDetectionTestBase.java - Issue 231693002: Remove some dependencies on ContentView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/ContentDetectionTestBase.java

Issue 231693002: Remove some dependencies on ContentView. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/contextmenu/ContextMenuUtils.java ('k') | content/public/android/javatests/src/org/chromium/content/browser/ContentViewLocationTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/javatests/src/org/chromium/content/browser/ContentDetectionTestBase.java

diff --git a/content/public/android/javatests/src/org/chromium/content/browser/ContentDetectionTestBase.java b/content/public/android/javatests/src/org/chromium/content/browser/ContentDetectionTestBase.java

index 64de8457de00b6a7ec612fbb8ed7cc5e726546fb..8319e2d5baa436c6c10bbafe8eac93e0977f33a0 100644

--- a/content/public/android/javatests/src/org/chromium/content/browser/ContentDetectionTestBase.java

+++ b/content/public/android/javatests/src/org/chromium/content/browser/ContentDetectionTestBase.java

@@ -66,8 +66,8 @@ public class ContentDetectionTestBase extends ContentShellTestBase {

callbackHelperContainer.getOnStartContentIntentHelper();

int currentCallCount = onStartContentIntentHelper.getCallCount();

- DOMUtils.scrollNodeIntoView(getContentViewCore(), callbackHelperContainer, id);

- DOMUtils.clickNode(this, getContentView(), callbackHelperContainer, id);

+ DOMUtils.scrollNodeIntoView(getContentViewCore(), id);

+ DOMUtils.clickNode(this, getContentView(), id);

onStartContentIntentHelper.waitForCallback(currentCallCount, 1, WAIT_TIMEOUT_SECONDS,

TimeUnit.SECONDS);

@@ -87,8 +87,8 @@ public class ContentDetectionTestBase extends ContentShellTestBase {

callbackHelperContainer.getOnPageFinishedHelper();

int currentCallCount = onPageFinishedHelper.getCallCount();

- DOMUtils.scrollNodeIntoView(getContentViewCore(), callbackHelperContainer, id);

- DOMUtils.clickNode(this, getContentView(), callbackHelperContainer, id);

+ DOMUtils.scrollNodeIntoView(getContentViewCore(), id);

+ DOMUtils.clickNode(this, getContentView(), id);

onPageFinishedHelper.waitForCallback(currentCallCount, 1, WAIT_TIMEOUT_SECONDS,

TimeUnit.SECONDS);