Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1142)

Issue 2314453002: Use CSSPrimitiveValue::create in CSSLengthInterpolationType (Closed)

Created:
4 years, 3 months ago by alancutter (OOO until 2018)
Modified:
4 years, 3 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use CSSPrimitiveValue::create in CSSLengthInterpolationType This change removes unnecessary code to convert an interpolable length into a CSS value by reusing existing code that converts a Length object into a CSSPrimitiveValue. This change also fixes up the assertion in CSSLengthInterpolationType::apply to not depend on AnimatableValues as well as making the surrounding comment more accurate as to its intentions. BUG=630487 Committed: https://crrev.com/830c24aa142db9bb04ca3ca74fce50636dd724b7 Cr-Commit-Position: refs/heads/master@{#416851}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -111 lines) Patch
M third_party/WebKit/Source/core/animation/BasicShapeInterpolationFunctions.cpp View 5 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSBorderImageLengthBoxInterpolationType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/CSSClipInterpolationType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/CSSFontSizeInterpolationType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp View 2 chunks +22 lines, -87 lines 1 comment Download
M third_party/WebKit/Source/core/animation/CSSLengthListInterpolationType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/CSSTextIndentInterpolationType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/CSSTranslateInterpolationType.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/animation/FilterInterpolationFunctions.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/ShadowInterpolationFunctions.cpp View 1 chunk +4 lines, -4 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
alancutter (OOO until 2018)
https://codereview.chromium.org/2314453002/diff/1/third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp File third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp (right): https://codereview.chromium.org/2314453002/diff/1/third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp#newcode275 third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp:275: DCHECK(before == after); This does not use DCHECK_EQ because ...
4 years, 3 months ago (2016-09-05 07:29:11 UTC) #2
suzyh_UTC10 (ex-contributor)
lgtm
4 years, 3 months ago (2016-09-06 00:15:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2314453002/1
4 years, 3 months ago (2016-09-07 03:56:49 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-07 05:28:06 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 05:30:34 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/830c24aa142db9bb04ca3ca74fce50636dd724b7
Cr-Commit-Position: refs/heads/master@{#416851}

Powered by Google App Engine
This is Rietveld 408576698