Code health: Add type checks to CSSLengthInterpolationType::nonInterpolableValuesAreCompatible()

Code health: Add type checks to CSSLengthInterpolationType::nonInterpolableValuesAreCompatible()

This change adds type checks to (marginally) improve readability of the
CSS length interpolation code.
The isNonInterpolableValue() helper functions are added along side the
existing toNonInterpolableValue() helper functions also for readability.

Committed: https://crrev.com/ae1576879137a0b96ad64f251f574c5b7efc4eba
Cr-Commit-Position: refs/heads/master@{#416833}

[alancutter (OOO until 2018), 2016-09-05 06:55:33]

alancutter@chromium.org changed reviewers:
+ suzyh@chromium.org

[suzyh_UTC10 (ex-contributor), 2016-09-06 00:08:10]

I'm happy with this, but please get a second OK from timloh or dstockwell since
I'm not confident with the C++/macro/style aspect.

[alancutter (OOO until 2018), 2016-09-06 00:20:43]

alancutter@chromium.org changed reviewers:
+ dstockwell@chromium.org

[alancutter (OOO until 2018), 2016-09-06 00:20:44]

+dstockwell for macros.

[alancutter (OOO until 2018), 2016-09-06 00:27:37]

The CQ bit was checked by alancutter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 00:27:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 01:46:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 01:46:42]

Dry run: This issue passed the CQ dry run.

[alancutter (OOO until 2018), 2016-09-07 01:42:53]

On 2016/09/06 at 00:20:44, alancutter wrote:
> +dstockwell for macros.

dstockwell: Poke.

[dstockwell, 2016-09-07 01:51:37]

lgtm

[alancutter (OOO until 2018), 2016-09-07 01:58:36]

The CQ bit was checked by alancutter@chromium.org

[commit-bot: I haz the power, 2016-09-07 01:58:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 03:20:12]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-07 03:22:34]

Description was changed from

==========
Code health: Add type checks to
CSSLengthInterpolationType::nonInterpolableValuesAreCompatible()

This change adds type checks to (marginally) improve readability of the
CSS length interpolation code.
The isNonInterpolableValue() helper functions are added along side the
existing toNonInterpolableValue() helper functions also for readability.
==========

to

==========
Code health: Add type checks to
CSSLengthInterpolationType::nonInterpolableValuesAreCompatible()

This change adds type checks to (marginally) improve readability of the
CSS length interpolation code.
The isNonInterpolableValue() helper functions are added along side the
existing toNonInterpolableValue() helper functions also for readability.

Committed: https://crrev.com/ae1576879137a0b96ad64f251f574c5b7efc4eba
Cr-Commit-Position: refs/heads/master@{#416833}
==========

[commit-bot: I haz the power, 2016-09-07 03:22:35]

Patchset 3 (id:??) landed as
https://crrev.com/ae1576879137a0b96ad64f251f574c5b7efc4eba
Cr-Commit-Position: refs/heads/master@{#416833}