third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.h - Issue 2314453002: Use CSSPrimitiveValue::create in CSSLengthInterpolationType

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.h

Issue 2314453002: Use CSSPrimitiveValue::create in CSSLengthInterpolationType (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/CSSFontSizeInterpolationType.cpp ('k') | third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp » ('j') | third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.h

diff --git a/third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.h b/third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.h

index 2537a204f4bc38e79d8ff24e243c4d9ae7c91791..a2f87a5320bbf8cc82fa191852034cc3fbd8b6e0 100644

--- a/third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.h

+++ b/third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.h

@@ -22,7 +22,7 @@ public:

void composite(UnderlyingValueOwner&, double underlyingFraction, const InterpolationValue&, double interpolationFraction) const final;

void apply(const InterpolableValue&, const NonInterpolableValue*, InterpolationEnvironment&) const final;

- static Length resolveInterpolableLength(const InterpolableValue&, const NonInterpolableValue*, const CSSToLengthConversionData&, ValueRange = ValueRangeAll);

+ static Length createLength(const InterpolableValue&, const NonInterpolableValue*, const CSSToLengthConversionData&, ValueRange = ValueRangeAll);

static std::unique_ptr<InterpolableValue> createInterpolablePixels(double pixels);

static InterpolationValue createInterpolablePercent(double percent);

static InterpolationValue maybeConvertCSSValue(const CSSValue&);