third_party/WebKit/Source/core/animation/CSSClipInterpolationType.cpp - Issue 2314453002: Use CSSPrimitiveValue::create in CSSLengthInterpolationType

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/CSSClipInterpolationType.cpp

Issue 2314453002: Use CSSPrimitiveValue::create in CSSLengthInterpolationType (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/CSSBorderImageLengthBoxInterpolationType.cpp ('k') | third_party/WebKit/Source/core/animation/CSSFontSizeInterpolationType.cpp » ('j') | third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/CSSClipInterpolationType.cpp

diff --git a/third_party/WebKit/Source/core/animation/CSSClipInterpolationType.cpp b/third_party/WebKit/Source/core/animation/CSSClipInterpolationType.cpp

index 668935de5d41d5573b7d9c3f8d54ce2205049d29..8cad2e94899abe4e139102eecd0e93443ed63720 100644

--- a/third_party/WebKit/Source/core/animation/CSSClipInterpolationType.cpp

+++ b/third_party/WebKit/Source/core/animation/CSSClipInterpolationType.cpp

@@ -255,7 +255,7 @@ void CSSClipInterpolationType::apply(const InterpolableValue& interpolableValue,

{

if (isAuto)

return Length(Auto);

- return CSSLengthInterpolationType::resolveInterpolableLength(*list.get(index), nullptr, environment.state().cssToLengthConversionData(), ValueRangeAll);

+ return CSSLengthInterpolationType::createLength(*list.get(index), nullptr, environment.state().cssToLengthConversionData(), ValueRangeAll);

};

environment.state().style()->setClip(LengthBox(

convertIndex(autos.isTopAuto, ClipTop),