third_party/WebKit/Source/core/animation/CSSLengthListInterpolationType.cpp - Issue 2314453002: Use CSSPrimitiveValue::create in CSSLengthInterpolationType

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/CSSLengthListInterpolationType.cpp

Issue 2314453002: Use CSSPrimitiveValue::create in CSSLengthInterpolationType (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp ('K') | « third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp ('k') | third_party/WebKit/Source/core/animation/CSSTextIndentInterpolationType.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/CSSLengthListInterpolationType.cpp

diff --git a/third_party/WebKit/Source/core/animation/CSSLengthListInterpolationType.cpp b/third_party/WebKit/Source/core/animation/CSSLengthListInterpolationType.cpp

index 0efabbd64d2351dc72175719f8109724c1936b9f..04f324b1a9d4199d154cbd27f59a97a4ce44c5b5 100644

--- a/third_party/WebKit/Source/core/animation/CSSLengthListInterpolationType.cpp

+++ b/third_party/WebKit/Source/core/animation/CSSLengthListInterpolationType.cpp

@@ -129,7 +129,7 @@ void CSSLengthListInterpolationType::apply(const InterpolableValue& interpolable

DCHECK_EQ(nonInterpolableList.length(), length);

Vector<Length> result(length);

for (size_t i = 0; i < length; i++) {

- result[i] = CSSLengthInterpolationType::resolveInterpolableLength(

+ result[i] = CSSLengthInterpolationType::createLength(

*interpolableList.get(i),

nonInterpolableList.get(i),

environment.state().cssToLengthConversionData(),