[CSSTypedOM] Computed StylePropertyMap use ComputedStyle for Lengths

[CSSTypedOM] Computed StylePropertyMap use ComputedStyle for Lengths

Currently only working for top, left, bottom, right, width, height.

I have removed the old code which returned resolved style values. This means that for now we support fewer properties, and I have marked some layout tests as expected failures. Will work on getting them passing again in follow-up patches.

BUG=648495

[rjwright, 2016-09-07 04:23:59]

Description was changed from

==========
[WIP][CSSTypedOM] Computed StylePropertyMap use ComputedStyle for Lengths
BUG=
==========

to

==========
[WIP][CSSTypedOM] Computed StylePropertyMap use ComputedStyle for Lengths

Currently only working for top, left, bottom, right, width, height.

Probably breaks a bunch of unit tests.

BUG=
==========

[rjwright, 2016-09-08 02:09:44]

Hmm. I guess I should store the ComputedStyle instead of the Node when we make
the ComputedStylePropertyMap. One the typedcssom/computedstyle/width test is
crashing (I've fixed the crash locally, but it's still failing) because the
element doesn't have a LayoutObject. Not sure why.

[meade_UTC10, 2016-09-09 01:56:26]

meade@chromium.org changed reviewers:
+ meade@chromium.org

[meade_UTC10, 2016-09-09 01:56:27]

https://codereview.chromium.org/2312293003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/cssom/CSSKeywordValue.h (right):

https://codereview.chromium.org/2312293003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/cssom/CSSKeywordValue.h:31: explicit
CSSKeywordValue(const AtomicString& keyword)
It's fine to create another create() method that only takes the AtomicString
keyword :)

https://codereview.chromium.org/2312293003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.h
(right):

https://codereview.chromium.org/2312293003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.h:46:
Member<Node> m_node;
Do we really need both the node and the computed StyleDeclaration?

https://codereview.chromium.org/2312293003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/cssom/StyleValueFactory.cpp (right):

https://codereview.chromium.org/2312293003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/cssom/StyleValueFactory.cpp:76:
CSSStyleValue* styleValueForProperty(CSSPropertyID propertyID, const
ComputedStyle* style)
Would it make more sense for this to be a series of functions that do, say

Length -> StyleValue

Which would more of the logic in the StylePropertyMap? Since this logic is only
used in ComputedStylePropertyMap (I think?), it'd make sense to keep as much of
the logic in there as possible.

[rjwright, 2016-09-21 01:26:08]

Description was changed from

==========
[WIP][CSSTypedOM] Computed StylePropertyMap use ComputedStyle for Lengths

Currently only working for top, left, bottom, right, width, height.

Probably breaks a bunch of unit tests.

BUG=
==========

to

==========
[WIP][CSSTypedOM] Computed StylePropertyMap use ComputedStyle for Lengths

Currently only working for top, left, bottom, right, width, height.

BUG=648495
==========

[rjwright, 2016-09-21 02:45:07]

Description was changed from

==========
[WIP][CSSTypedOM] Computed StylePropertyMap use ComputedStyle for Lengths

Currently only working for top, left, bottom, right, width, height.

BUG=648495
==========

to

==========
[CSSTypedOM] Computed StylePropertyMap use ComputedStyle for Lengths

Currently only working for top, left, bottom, right, width, height.

I have removed the old code which returned resolved style values. This means
that for now we support fewer properties, and I have marked some layout tests as
expected failures. Will work on getting them passing again in follow-up patches.

BUG=648495
==========

[rjwright, 2016-09-21 05:40:55]

rjwright@chromium.org changed reviewers:
+ haraken@chromium.org

[rjwright, 2016-09-21 05:49:55]

The CQ bit was checked by rjwright@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 05:50:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 05:52:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 05:52:20]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[rjwright1, 2016-09-22 00:51:33]

rjwright@google.com changed reviewers:
+ rjwright@google.com

[meade_UTC10, 2016-09-22 05:34:36]

https://codereview.chromium.org/2312293003/diff/180001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/css/cssom/CSSCalcLength.cpp (right):

https://codereview.chromium.org/2312293003/diff/180001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/cssom/CSSCalcLength.cpp:77:
result->set(values.pixels, CSSPrimitiveValue::UnitType::Pixels);
Shouldn't fixed lengths become CSSSimpleLengths? (you may need to move this
logic up to CSSLengthValue)

https://codereview.chromium.org/2312293003/diff/180001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp
(right):

https://codereview.chromium.org/2312293003/diff/180001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp:60: if
(!styleValue) {
I think it's clearer, and you can save a level of nesting if you invert this if
statement:

...

if (styleValue) {
  styleValueVector.append(styleValue);
  return styleValueVector;
}

const CSSValue* cssValue =
m_computedStyleDeclaration->getPropertyCSSValueInternal(propertyID);
if (cssValue)
  return StyleValueFactory::unsupportedCSSValue(*cssValue);

return styleValueVector;

https://codereview.chromium.org/2312293003/diff/180001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.h
(right):

https://codereview.chromium.org/2312293003/diff/180001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.h:36: ,
m_node(node) { m_computedStyleDeclaration =
CSSComputedStyleDeclaration::create(node, false, pseudoElement); }
Nit: It'd be nice to put this on a new line, or you can do

ComputedStylePropertyMap(Node* node, const String& pseudoElement = String())
: ImmutableStylePropertyMap()
, m_computedStyleDeclaration(CSSComputedStyleDeclaration::create(node, false,
pseudoElement)
, m_node(node) { }

[rjwright, 2016-09-23 04:50:04]

https://codereview.chromium.org/2312293003/diff/180001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/css/cssom/CSSCalcLength.cpp (right):

https://codereview.chromium.org/2312293003/diff/180001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/cssom/CSSCalcLength.cpp:77:
result->set(values.pixels, CSSPrimitiveValue::UnitType::Pixels);
On 2016/09/22 05:34:35, Eddy wrote:
> Shouldn't fixed lengths become CSSSimpleLengths? (you may need to move this
> logic up to CSSLengthValue)

This is not even reached so I just removed it.

https://codereview.chromium.org/2312293003/diff/180001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp
(right):

https://codereview.chromium.org/2312293003/diff/180001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp:60: if
(!styleValue) {
On 2016/09/22 05:34:35, Eddy wrote:
> I think it's clearer, and you can save a level of nesting if you invert this
if
> statement:
> 
> ...
> 
> if (styleValue) {
>   styleValueVector.append(styleValue);
>   return styleValueVector;
> }
> 
> const CSSValue* cssValue =
> m_computedStyleDeclaration->getPropertyCSSValueInternal(propertyID);
> if (cssValue)
>   return StyleValueFactory::unsupportedCSSValue(*cssValue);
> 
> return styleValueVector;

Done.

But I'm kinda unsure about our decision to use resolved style cssText to make an
unsupportedCSSValue. Wondering if we should go back to returning an empty
vector. Maybe we should chat to some other people (Shane, Doug?) and get their
opinion.

https://codereview.chromium.org/2312293003/diff/180001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.h
(right):

https://codereview.chromium.org/2312293003/diff/180001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.h:36: ,
m_node(node) { m_computedStyleDeclaration =
CSSComputedStyleDeclaration::create(node, false, pseudoElement); }
On 2016/09/22 05:34:35, Eddy wrote:
> Nit: It'd be nice to put this on a new line, or you can do
> 
> ComputedStylePropertyMap(Node* node, const String& pseudoElement = String())
> : ImmutableStylePropertyMap()
> , m_computedStyleDeclaration(CSSComputedStyleDeclaration::create(node, false,
> pseudoElement)
> , m_node(node) { }

Done.

[meade_UTC10, 2016-09-23 05:21:25]

lgtm

https://codereview.chromium.org/2312293003/diff/200001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp
(right):

https://codereview.chromium.org/2312293003/diff/200001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp:15:
CSSStyleValue* styleValueForLengthProperty(const Length& length)
nit: just styleValueForLength for brevity? (also you don't have the property
here, so...)

[rjwright, 2016-09-23 05:39:29]

https://codereview.chromium.org/2312293003/diff/200001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp
(right):

https://codereview.chromium.org/2312293003/diff/200001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp:15:
CSSStyleValue* styleValueForLengthProperty(const Length& length)
On 2016/09/23 05:21:25, Eddy wrote:
> nit: just styleValueForLength for brevity? (also you don't have the property
> here, so...)

Done.

[rjwright, 2016-09-23 05:39:58]

The CQ bit was checked by rjwright@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 05:40:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 05:42:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 05:42:23]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[rjwright, 2016-09-26 01:09:11]

The CQ bit was checked by rjwright@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-26 01:09:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 01:11:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 01:11:42]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[rjwright, 2016-09-26 03:42:21]

The CQ bit was checked by rjwright@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-26 03:42:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rjwright, 2016-09-26 04:13:41]

rjwright@chromium.org changed reviewers:
+ dstockwell@chromium.org
- haraken@chromium.org, rjwright@google.com

[commit-bot: I haz the power, 2016-09-26 06:23:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 06:23:04]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[meade_UTC10, 2016-09-27 04:41:39]

https://codereview.chromium.org/2312293003/diff/240001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/css/cssom/CSSCalcLength.cpp (right):

https://codereview.chromium.org/2312293003/diff/240001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/cssom/CSSCalcLength.cpp:71: CSSCalcLength*
CSSCalcLength::fromLength(const Length& length)
[no action required] btw I'm implementing CSSCalcExpressionNode -> CSSCalcLength
in https://codereview.chromium.org/2371673002/, we may be able to use that
instead of this later.

https://codereview.chromium.org/2312293003/diff/240001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/css/cssom/CSSCalcLength.h (right):

https://codereview.chromium.org/2312293003/diff/240001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/cssom/CSSCalcLength.h:60: CSSLengthValue*
addInternal(const CSSLengthValue* other) override;
Nit: no need for extra indent?

https://codereview.chromium.org/2312293003/diff/240001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp
(right):

https://codereview.chromium.org/2312293003/diff/240001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp:15:
CSSStyleValue* styleValueForLength(const Length& length)
Nit: It's conventional to put pure methods like this in anonymous namespaces to
avoid polluting the blink namespace.

https://codereview.chromium.org/2312293003/diff/240001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp:38: //
Need to look back to it and see if I need to do more here.
Did you end up asking anyone about this?

https://codereview.chromium.org/2312293003/diff/240001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp:70: return
StyleValueFactory::unsupportedCSSValue(*cssValue);
We're going to get rid of UnsupportedCSSValue after all (decided at TPAC last
week), so you can remove this :)

[rjwright, 2016-09-28 01:38:24]

https://codereview.chromium.org/2312293003/diff/240001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/css/cssom/CSSCalcLength.h (right):

https://codereview.chromium.org/2312293003/diff/240001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/cssom/CSSCalcLength.h:60: CSSLengthValue*
addInternal(const CSSLengthValue* other) override;
On 2016/09/27 04:41:39, Eddy wrote:
> Nit: no need for extra indent?

Done.

https://codereview.chromium.org/2312293003/diff/240001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp
(right):

https://codereview.chromium.org/2312293003/diff/240001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp:15:
CSSStyleValue* styleValueForLength(const Length& length)
On 2016/09/27 04:41:39, Eddy wrote:
> Nit: It's conventional to put pure methods like this in anonymous namespaces
to
> avoid polluting the blink namespace.

Done.

https://codereview.chromium.org/2312293003/diff/240001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp:38: //
Need to look back to it and see if I need to do more here.
On 2016/09/27 04:41:39, Eddy wrote:
> Did you end up asking anyone about this?

No. I'm not sure who to ask. I was planning to just suss it out and add it in a
follow up. Shall we get it sorted before landing this?

https://codereview.chromium.org/2312293003/diff/240001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp:70: return
StyleValueFactory::unsupportedCSSValue(*cssValue);
On 2016/09/27 04:41:39, Eddy wrote:
> We're going to get rid of UnsupportedCSSValue after all (decided at TPAC last
> week), so you can remove this :) 

Done.

[meade_UTC10, 2016-09-28 01:51:32]

https://codereview.chromium.org/2312293003/diff/240001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp
(right):

https://codereview.chromium.org/2312293003/diff/240001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp:38: //
Need to look back to it and see if I need to do more here.
On 2016/09/28 01:38:24, rjwright wrote:
> On 2016/09/27 04:41:39, Eddy wrote:
> > Did you end up asking anyone about this?
> 
> No. I'm not sure who to ask. I was planning to just suss it out and add it in
a
> follow up. Shall we get it sorted before landing this?

No strong opinions - but we may be able to ask Bugs+Naina, or Shane?

[nainar, 2016-09-28 02:53:24]

nainar@chromium.org changed reviewers:
+ nainar@chromium.org

[nainar, 2016-09-28 02:53:26]

As per real life discussion with meade@

https://codereview.chromium.org/2312293003/diff/280001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp
(right):

https://codereview.chromium.org/2312293003/diff/280001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp:43:
document.updateStyleAndLayoutTreeForNode(m_node);
this should instead be like CSSComputedStyleDeclaration::styledNode()
(https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/css/CSSCo...)
not m_node -> so that you can get the PseudoElement's ComputedStyle

https://codereview.chromium.org/2312293003/diff/280001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp:44: const
ComputedStyle* style = m_node->ensureComputedStyle();
This needs to be expanded to cater to the case of PseudoElements like is being
done in computeComputedStyle here:
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/css/CSSCo...

More specifically: styledNode->ensureComputedStyle(styledNode->isPseudoElement()
? PseudoIdNone : m_pseudoElementSpecifier);

[rjwright, 2016-09-29 04:00:28]

In the latest patch set (#16) I have added ComputedStylePropertyMap as a friend
of CSSComputedStyleDeclaration, and made
ComputedStylePropertyMap.m_computedStyleDeclaration a
CSSComputedStyleDeclaration istead of a CSSStyleDeclaration. Previously we were
using CSSStyleDeclaration because it exposes some of the methods that are
private in CSSComputedStyleDeclaration (e.g. length), however I wanted to access
CSSComputedStyleDeclaration::styledNode(), and adding that to
CSSStyleDeclaration doesn't make sense. I also think that using friendship is
more sensible than using the (overly broad) parent class to access private
methods on the subclass. I would have just made the requisite methods public,
but there is a comment warning "// CSSOM functions. Don't make these public.".

I have also changed some logic in
CSSComputedStyleDeclaration::computeComputedStyle() which should probably be in
a separate CL.

[rjwright, 2016-09-29 04:08:17]

https://codereview.chromium.org/2312293003/diff/300001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.h
(right):

https://codereview.chromium.org/2312293003/diff/300001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.h:19: static
ComputedStylePropertyMap* create(Node* node, const String& pseudoElement)
I think I can change this back now, once we decide on how the style recalc stuff
in getAllInternal is going to work.

[rjwright, 2016-09-29 06:15:01]

I still need to double-check my style recalc stuff, as per code comments. I also
really should test some pseudoelement stuff.

[rjwright, 2016-09-29 06:28:57]

The CQ bit was checked by rjwright@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 06:29:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 06:31:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 06:31:59]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[rjwright, 2016-09-29 06:39:11]

The CQ bit was checked by rjwright@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 06:39:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 08:01:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 08:01:13]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[rjwright, 2016-09-29 11:18:09]

The CQ bit was checked by rjwright@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 11:18:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 11:22:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 11:22:36]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[nainar, 2016-10-10 00:29:19]

nainar@chromium.org changed reviewers:
- nainar@chromium.org