Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Unified Diff: third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.h

Issue 2312293003: [CSSTypedOM] Computed StylePropertyMap use ComputedStyle for Lengths (Closed)
Patch Set: rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.h
diff --git a/third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.h b/third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.h
index 9d3947cb3dac150843a5e20bfc2230cb3b89cf3b..b4a77554b5317018fb7b884f38d488a9eb5b868e 100644
--- a/third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.h
+++ b/third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.h
@@ -73,6 +73,12 @@ class CORE_EXPORT CSSComputedStyleDeclaration final
MutableStylePropertySet* copyPropertiesInSet(
const Vector<CSSPropertyID>&) const;
+ // CSSOM functions.
+ unsigned length() const override;
+ String item(unsigned index) const override;
+ const CSSValue* getPropertyCSSValueInternal(
+ AtomicString customPropertyName) override;
+
DECLARE_VIRTUAL_TRACE();
private:
@@ -85,10 +91,8 @@ class CORE_EXPORT CSSComputedStyleDeclaration final
// fix that.
Node* styledNode() const;
- // CSSOM functions. Don't make these public.
+ // CSSOM functions.
CSSRule* parentRule() const override;
- unsigned length() const override;
- String item(unsigned index) const override;
const ComputedStyle* computeComputedStyle() const;
String getPropertyValue(const String& propertyName) override;
String getPropertyPriority(const String& propertyName) override;
@@ -104,8 +108,6 @@ class CORE_EXPORT CSSComputedStyleDeclaration final
String cssText() const override;
void setCSSText(const String&, ExceptionState&) override;
const CSSValue* getPropertyCSSValueInternal(CSSPropertyID) override;
- const CSSValue* getPropertyCSSValueInternal(
- AtomicString customPropertyName) override;
String getPropertyValueInternal(CSSPropertyID) override;
void setPropertyInternal(CSSPropertyID,
const String& customPropertyName,

Powered by Google App Engine
This is Rietveld 408576698