[CSSTypedOM] Computed StylePropertyMap use ComputedStyle for Lengths

third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp

 // Copyright 2016 the Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/css/cssom/ComputedStylePropertyMap.h"
 
 #include "core/css/CSSComputedStyleDeclaration.h"
+#include "core/css/cssom/CSSCalcLength.h"
+#include "core/css/cssom/CSSKeywordValue.h"
+#include "core/css/cssom/CSSSimpleLength.h"
 #include "core/css/cssom/StyleValueFactory.h"
 
 namespace blink {
 
+namespace {
+
+CSSStyleValue* styleValueForLength(const Length& length)
+{
+    if (length.isAuto()) {
+        return CSSKeywordValue::create("auto");
+    }
+    if (length.isFixed()) {
+        return CSSSimpleLength::create(length.pixels(), CSSPrimitiveValue::UnitType::Pixels);
+    }
+    if (length.isPercent()) {
+        return CSSSimpleLength::create(length.percent(), CSSPrimitiveValue::UnitType::Percentage);
+    }
+    if (length.isCalculated()) {
+        return CSSCalcLength::fromLength(length);
+    }
+    NOTREACHED();
+    return nullptr;
+}
+
+} // namespace
+
 CSSStyleValueVector ComputedStylePropertyMap::getAllInternal(CSSPropertyID propertyID)
 {
-    const CSSValue* cssValue = m_computedStyleDeclaration->getPropertyCSSValueInternal(propertyID);
-    if (!cssValue)
-        return CSSStyleValueVector();
-    return StyleValueFactory::cssValueToStyleValueVector(propertyID, *cssValue);
+    Document& document = m_node->document();
+    // TODO(rjwright): This style recalc is copied from
+    // CSSComputedStyleDeclaration::getPropertyValue, which also does a bunch of other stuff.
+    // Need to look back to it and see if I need to do more here.
+    document.updateStyleAndLayoutTreeForNode(m_node);

[nainar, 2016/09/28 02:53:25]

this should instead be like CSSComputedStyleDeclaration::styledNode()
(https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/css/CSSCo...)
not m_node -> so that you can get the PseudoElement's ComputedStyle

+    const ComputedStyle* style = m_node->ensureComputedStyle();

[nainar, 2016/09/28 02:53:25]

This needs to be expanded to cater to the case of PseudoElements like is being
done in computeComputedStyle here:
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/css/CSSCo...

More specifically: styledNode->ensureComputedStyle(styledNode->isPseudoElement()
? PseudoIdNone : m_pseudoElementSpecifier);

+    CSSStyleValueVector styleValueVector;
+    CSSStyleValue* styleValue = nullptr;
+    switch (propertyID) {
+    case CSSPropertyLeft:
+        styleValue = styleValueForLength(style->left());
+    case CSSPropertyRight:
+        styleValue = styleValueForLength(style->right());
+    case CSSPropertyTop:
+        styleValue = styleValueForLength(style->top());
+    case CSSPropertyBottom:
+        styleValue = styleValueForLength(style->bottom());
+    case CSSPropertyHeight:
+        styleValue = styleValueForLength(style->height());
+    case CSSPropertyWidth:
+        styleValue = styleValueForLength(style->width());
+    default:
+        break;
+    }
+
+    if (styleValue) {
+        styleValueVector.append(styleValue);
+    }
+    return styleValueVector;
 }
 
 CSSStyleValueVector ComputedStylePropertyMap::getAllInternal(AtomicString customPropertyName)
 {
     const CSSValue* cssValue = m_computedStyleDeclaration->getPropertyCSSValueInternal(customPropertyName);
     if (!cssValue)
         return CSSStyleValueVector();
     return StyleValueFactory::cssValueToStyleValueVector(CSSPropertyInvalid, *cssValue);
 }
 
 Vector<String> ComputedStylePropertyMap::getProperties()
 {
     Vector<String> result;
     for (unsigned i = 0; i < m_computedStyleDeclaration->length(); i++) {
         result.append(m_computedStyleDeclaration->item(i));
     }
     return result;
 }
 
 } // namespace blink