Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Unified Diff: third_party/WebKit/Source/core/css/cssom/FilteredComputedStylePropertyMapTest.cpp

Issue 2312293003: [CSSTypedOM] Computed StylePropertyMap use ComputedStyle for Lengths (Closed)
Patch Set: rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/cssom/FilteredComputedStylePropertyMapTest.cpp
diff --git a/third_party/WebKit/Source/core/css/cssom/FilteredComputedStylePropertyMapTest.cpp b/third_party/WebKit/Source/core/css/cssom/FilteredComputedStylePropertyMapTest.cpp
index 31484f4d879190ce1539685ada45198659c3fe40..df583a444fe5442ecb9ef20bc1d7da6ea009d073 100644
--- a/third_party/WebKit/Source/core/css/cssom/FilteredComputedStylePropertyMapTest.cpp
+++ b/third_party/WebKit/Source/core/css/cssom/FilteredComputedStylePropertyMapTest.cpp
@@ -23,6 +23,7 @@ class FilteredComputedStylePropertyMapTest : public ::testing::Test {
CSSComputedStyleDeclaration* declaration() const {
return m_declaration.get();
}
+ Node* pageNode() { return m_page->document().documentElement(); }
private:
std::unique_ptr<DummyPageHolder> m_page;
@@ -38,19 +39,19 @@ TEST_F(FilteredComputedStylePropertyMapTest, GetProperties) {
FilteredComputedStylePropertyMap* map =
FilteredComputedStylePropertyMap::create(declaration(), nativeProperties,
- customProperties);
+ customProperties, pageNode());
EXPECT_TRUE(map->getProperties().contains("color"));
EXPECT_TRUE(map->getProperties().contains("align-items"));
EXPECT_TRUE(map->getProperties().contains("--foo"));
EXPECT_TRUE(map->getProperties().contains("--bar"));
map = FilteredComputedStylePropertyMap::create(
- declaration(), nativeProperties, emptyCustomProperties);
+ declaration(), nativeProperties, emptyCustomProperties, pageNode());
EXPECT_TRUE(map->getProperties().contains("color"));
EXPECT_TRUE(map->getProperties().contains("align-items"));
map = FilteredComputedStylePropertyMap::create(
- declaration(), emptyNativeProperties, customProperties);
+ declaration(), emptyNativeProperties, customProperties, pageNode());
EXPECT_TRUE(map->getProperties().contains("--foo"));
EXPECT_TRUE(map->getProperties().contains("--bar"));
}
@@ -60,8 +61,8 @@ TEST_F(FilteredComputedStylePropertyMapTest, NativePropertyAccessors) {
{CSSPropertyColor, CSSPropertyAlignItems});
Vector<AtomicString> emptyCustomProperties;
FilteredComputedStylePropertyMap* map =
- FilteredComputedStylePropertyMap::create(declaration(), nativeProperties,
- emptyCustomProperties);
+ FilteredComputedStylePropertyMap::create(
+ declaration(), nativeProperties, emptyCustomProperties, pageNode());
TrackExceptionState exceptionState;
@@ -92,7 +93,7 @@ TEST_F(FilteredComputedStylePropertyMapTest, CustomPropertyAccessors) {
Vector<AtomicString> customProperties({"--foo", "--bar"});
FilteredComputedStylePropertyMap* map =
FilteredComputedStylePropertyMap::create(
- declaration(), emptyNativeProperties, customProperties);
+ declaration(), emptyNativeProperties, customProperties, pageNode());
TrackExceptionState exceptionState;

Powered by Google App Engine
This is Rietveld 408576698