[CSSTypedOM] Computed StylePropertyMap use ComputedStyle for Lengths

third_party/WebKit/Source/core/css/cssom/CSSCalcLength.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/css/cssom/CSSCalcLength.h"
 
 #include "core/css/CSSCalculationValue.h"
 #include "core/css/CSSPrimitiveValue.h"
 #include "core/css/cssom/CSSCalcDictionary.h"
 #include "core/css/cssom/CSSSimpleLength.h"
@@ skipping 50 matching lines @@
     setFromDictValue(in, In, Inches)
     setFromDictValue(pc, Pc, Picas)
     setFromDictValue(pt, Pt, Points)
 
     if (numSet == 0) {
         exceptionState.throwTypeError("Must specify at least one value in CSSCalcDictionary for creating a CSSCalcLength.");
     }
     return result;
 }
 
+CSSCalcLength* CSSCalcLength::fromLength(const Length& length)
+{
+    DCHECK(length.isSpecified());
+    PixelsAndPercent values = length.getPixelsAndPercent();
+    CSSCalcLength* result = new CSSCalcLength();
+    if (length.isFixed()) {
+        result->set(values.pixels, CSSPrimitiveValue::UnitType::Pixels);

[meade_UTC10, 2016/09/22 05:34:35]

Shouldn't fixed lengths become CSSSimpleLengths? (you may need to move this
logic up to CSSLengthValue)

[rjwright, 2016/09/23 04:50:03]

This is not even reached so I just removed it.

+        return result;
+    }
+    if (length.isPercent()) {
+        result->set(values.percent, CSSPrimitiveValue::UnitType::Percentage);
+        return result;
+    }
+    result->set(values.pixels, CSSPrimitiveValue::UnitType::Pixels);
+    result->set(values.percent, CSSPrimitiveValue::UnitType::Percentage);
+    return result;
+}
+
 bool CSSCalcLength::containsPercent() const
 {
     return has(CSSPrimitiveValue::UnitType::Percentage);
 }
 
 CSSLengthValue* CSSCalcLength::addInternal(const CSSLengthValue* other, ExceptionState& exceptionState)
 {
     CSSCalcLength* result = CSSCalcLength::create(other, exceptionState);
     for (int i = 0; i < CSSLengthValue::kNumSupportedUnits; ++i) {
         if (hasAtIndex(i)) {
@@ skipping 61 matching lines @@
     }
     return CSSPrimitiveValue::create(CSSCalcValue::create(node));
 }
 
 int CSSCalcLength::indexForUnit(CSSPrimitiveValue::UnitType unit)
 {
     return (static_cast<int>(unit) - static_cast<int>(CSSPrimitiveValue::UnitType::Percentage));
 }
 
 } // namespace blink