third_party/WebKit/Source/core/css/cssom/CSSCalcLength.h - Issue 2312293003: [CSSTypedOM] Computed StylePropertyMap use ComputedStyle for Lengths

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/cssom/CSSCalcLength.h

Issue 2312293003: [CSSTypedOM] Computed StylePropertyMap use ComputedStyle for Lengths (Closed)

Patch Set: rebase Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/cssom/CSSCalcLength.h

diff --git a/third_party/WebKit/Source/core/css/cssom/CSSCalcLength.h b/third_party/WebKit/Source/core/css/cssom/CSSCalcLength.h

index 680718b63e009e5bf74437b33796760870c3b301..f4b845e85ac875b615fd383e9fc5dc21d7c884aa 100644

--- a/third_party/WebKit/Source/core/css/cssom/CSSCalcLength.h

+++ b/third_party/WebKit/Source/core/css/cssom/CSSCalcLength.h

@@ -24,6 +24,8 @@ class CORE_EXPORT CSSCalcLength final : public CSSLengthValue {

}

static CSSCalcLength* fromCSSValue(const CSSPrimitiveValue&);

+ static CSSCalcLength* fromLength(const Length&);

#define GETTER_MACRO(name, type) \

double name(bool& isNull) { \

isNull = !hasAtIndex(indexForUnit(type)); \