Added Hand attribute to Gamepad

Added Hand attribute to Gamepad

BUG=628417
Committed: https://crrev.com/764adf58736bd388d5fdb217862f94894ef1850f
Cr-Commit-Position: refs/heads/master@{#419687}

[bajones, 2016-09-18 22:45:33]

bajones@chromium.org changed reviewers:
+ bbudge@chromium.org, mkwst@chromium.org

[bajones, 2016-09-18 22:45:34]

bbudge@chromium.org: Please review changes in ppapi/

mkwst@chromium.org: Please review changes in modules/ and platform/

[bbudge, 2016-09-19 19:18:41]

ppapi lgtm

[bajones, 2016-09-19 21:58:29]

bajones@chromium.org changed reviewers:
+ aelias@chromium.org

[bajones, 2016-09-19 21:58:30]

aelias@: Could you review the public/platform/ here as well?

[bajones, 2016-09-19 22:29:11]

The CQ bit was checked by bajones@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 22:29:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2016-09-19 23:55:12]

haraken@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2016-09-19 23:55:13]

https://codereview.chromium.org/2300883003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/gamepad/Gamepad.cpp (right):

https://codereview.chromium.org/2300883003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/gamepad/Gamepad.cpp:86: break;

Add default: NOTREACHED().

https://codereview.chromium.org/2300883003/diff/40001/third_party/WebKit/publ...
File third_party/WebKit/public/platform/WebGamepad.h (right):

https://codereview.chromium.org/2300883003/diff/40001/third_party/WebKit/publ...
third_party/WebKit/public/platform/WebGamepad.h:150:
static_assert(sizeof(WebGamepad) == 842, "WebGamepad has wrong size");

I'm just curious but is this assert useful? WebGamepad is already big enough so
the size wouldn't matter.

[bajones, 2016-09-20 00:12:04]

On 2016/09/19 23:55:13, haraken wrote:
> Add default: NOTREACHED().

Done.

> I'm just curious but is this assert useful? WebGamepad is already big enough
so
> the size wouldn't matter.

I have no idea what this assert is for, to be honest. It existed before I get
around to maintaining the gamepad code. Removing it would make me SOOOOOOOOOOO
happy, though!

[bajones, 2016-09-20 00:27:21]

The CQ bit was checked by bajones@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 00:28:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 01:40:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 01:40:02]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[aelias_OOO_until_Jul13, 2016-09-20 04:10:36]

public/platform/ lgtm.

I would also lgtm a patch to delete all those static_assert()s.  I don't think
there is much value.  This pattern is only useful for when size of something is
performance-critical and liable to change by accident, and I'd say neither is
the case here.

[bajones, 2016-09-20 05:06:13]

The CQ bit was checked by bajones@chromium.org

[bajones, 2016-09-20 05:06:13]

The patchset sent to the CQ was uploaded after l-g-t-m from bbudge@chromium.org
Link to the patchset: https://codereview.chromium.org/2300883003/#ps60001
(title: "Address haraken@'s feedback")

[commit-bot: I haz the power, 2016-09-20 05:06:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 05:39:36]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-20 05:41:33]

Description was changed from

==========
Added Hand attribute to Gamepad

BUG=628417
==========

to

==========
Added Hand attribute to Gamepad

BUG=628417

Committed: https://crrev.com/764adf58736bd388d5fdb217862f94894ef1850f
Cr-Commit-Position: refs/heads/master@{#419687}
==========

[commit-bot: I haz the power, 2016-09-20 05:41:34]

Patchset 4 (id:??) landed as
https://crrev.com/764adf58736bd388d5fdb217862f94894ef1850f
Cr-Commit-Position: refs/heads/master@{#419687}