Use controller from SecurityInterstitialPage in derived classes

Use controller from SecurityInterstitialPage in derived classes

BUG=643366
Committed: https://crrev.com/9de01454fe7e379925b2bb1100e9b14c5cad535a
Cr-Commit-Position: refs/heads/master@{#417748}

[meacer, 2016-09-01 21:37:36]

The CQ bit was checked by meacer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 21:38:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 22:40:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 22:40:46]

Dry run: This issue passed the CQ dry run.

[meacer, 2016-09-01 23:02:53]

meacer@chromium.org changed reviewers:
+ felt@chromium.org

[meacer, 2016-09-01 23:02:54]

PTAL?

[meacer, 2016-09-02 00:13:38]

The CQ bit was checked by meacer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 00:14:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 00:18:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 00:18:02]

Dry run: This issue passed the CQ dry run.

[felt, 2016-09-07 17:02:49]

Can you rebase this on top of https://codereview.chromium.org/2303413002/? (Or
since you have an l-g-t-m for that one, maybe land that one, then do a git
rebase-update on this one?)

[meacer, 2016-09-07 17:32:15]

On 2016/09/07 17:02:49, felt wrote:
> Can you rebase this on top of https://codereview.chromium.org/2303413002/ (Or
> since you have an l-g-t-m for that one, maybe land that one, then do a git
> rebase-update on this one?)

Sorry for not making this clear: this is the very first CL. 2303413002 depends
on this one, so I'll rebase that one instead once this is landed.

[meacer, 2016-09-08 19:09:44]

Ping

[felt, 2016-09-08 20:07:47]

https://codereview.chromium.org/2298613007/diff/1/chrome/browser/ssl/bad_cloc...
File chrome/browser/ssl/bad_clock_blocking_page.h (right):

https://codereview.chromium.org/2298613007/diff/1/chrome/browser/ssl/bad_cloc...
chrome/browser/ssl/bad_clock_blocking_page.h:68: void AfterShow() override {}
if it's empty now can you just remove it? (or ist ehre no default
implementation)

https://codereview.chromium.org/2298613007/diff/1/chrome/browser/ssl/ssl_bloc...
File chrome/browser/ssl/ssl_blocking_page.cc (left):

https://codereview.chromium.org/2298613007/diff/1/chrome/browser/ssl/ssl_bloc...
chrome/browser/ssl/ssl_blocking_page.cc:186:
controller_->set_interstitial_page(interstitial_page());
where did this move to / why isn't it needed anymore?

[meacer, 2016-09-08 21:10:12]

The CQ bit was checked by meacer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 21:10:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 22:11:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 22:11:49]

Dry run: This issue passed the CQ dry run.

[meacer, 2016-09-08 22:18:20]

https://codereview.chromium.org/2298613007/diff/1/chrome/browser/ssl/bad_cloc...
File chrome/browser/ssl/bad_clock_blocking_page.h (right):

https://codereview.chromium.org/2298613007/diff/1/chrome/browser/ssl/bad_cloc...
chrome/browser/ssl/bad_clock_blocking_page.h:68: void AfterShow() override {}
On 2016/09/08 20:07:47, felt wrote:
> if it's empty now can you just remove it? (or ist ehre no default
> implementation)

There was no default implementation. I added one now.

https://codereview.chromium.org/2298613007/diff/1/chrome/browser/ssl/ssl_bloc...
File chrome/browser/ssl/ssl_blocking_page.cc (left):

https://codereview.chromium.org/2298613007/diff/1/chrome/browser/ssl/ssl_bloc...
chrome/browser/ssl/ssl_blocking_page.cc:186:
controller_->set_interstitial_page(interstitial_page());
On 2016/09/08 20:07:47, felt wrote:
> where did this move to / why isn't it needed anymore?

SecurityInterstitialPage::Show already does this. This is now unneeded since we
are using SecurityInterstitialPage's controller.

[felt, 2016-09-08 22:50:44]

lgtm

[meacer, 2016-09-08 22:52:05]

The CQ bit was checked by meacer@chromium.org

[commit-bot: I haz the power, 2016-09-08 22:52:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 22:59:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 22:59:28]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[meacer, 2016-09-08 23:06:05]

meacer@chromium.org changed reviewers:
+ nparker@chromium.org

[meacer, 2016-09-08 23:06:06]

Nathan: Can you PTAL at chrome/browser/safe_browsing/*? Thanks.

[Nathan Parker, 2016-09-09 21:29:15]

lgtm

[meacer, 2016-09-09 21:32:46]

The CQ bit was checked by meacer@chromium.org

[commit-bot: I haz the power, 2016-09-09 21:33:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 22:54:47]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-09 22:59:06]

Description was changed from

==========
Use controller from SecurityInterstitialPage in derived classes

BUG=643366
==========

to

==========
Use controller from SecurityInterstitialPage in derived classes

BUG=643366

Committed: https://crrev.com/9de01454fe7e379925b2bb1100e9b14c5cad535a
Cr-Commit-Position: refs/heads/master@{#417748}
==========

[commit-bot: I haz the power, 2016-09-09 22:59:07]

Patchset 2 (id:??) landed as
https://crrev.com/9de01454fe7e379925b2bb1100e9b14c5cad535a
Cr-Commit-Position: refs/heads/master@{#417748}