Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(694)

Unified Diff: chrome/browser/ssl/ssl_blocking_page.cc

Issue 2298613007: Use controller from SecurityInterstitialPage in derived classes (Closed)
Patch Set: Provide default impl for SecurityInterstitialPage::AfterShow Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ssl/ssl_blocking_page.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ssl/ssl_blocking_page.cc
diff --git a/chrome/browser/ssl/ssl_blocking_page.cc b/chrome/browser/ssl/ssl_blocking_page.cc
index 0672e235e7305e9d801c7ebf82bfa755d78a5f5d..2e5dea0f3a4ac889a392c73728b333285f3739ab 100644
--- a/chrome/browser/ssl/ssl_blocking_page.cc
+++ b/chrome/browser/ssl/ssl_blocking_page.cc
@@ -123,8 +123,7 @@ SSLBlockingPage::SSLBlockingPage(
options_mask,
Profile::FromBrowserContext(web_contents->GetBrowserContext()))),
expired_but_previously_allowed_(
- (options_mask & SSLErrorUI::EXPIRED_BUT_PREVIOUSLY_ALLOWED) != 0),
- controller_(new ChromeControllerClient(web_contents)) {
+ (options_mask & SSLErrorUI::EXPIRED_BUT_PREVIOUSLY_ALLOWED) != 0) {
// Override prefs for the SSLErrorUI.
Profile* profile =
Profile::FromBrowserContext(web_contents->GetBrowserContext());
@@ -149,16 +148,16 @@ SSLBlockingPage::SSLBlockingPage(
new ChromeMetricsHelper(web_contents, request_url, reporting_info,
GetSamplingEventName(overridable_, cert_error));
chrome_metrics_helper->StartRecordingCaptivePortalMetrics(overridable_);
- controller_->set_metrics_helper(base::WrapUnique(chrome_metrics_helper));
+ controller()->set_metrics_helper(base::WrapUnique(chrome_metrics_helper));
cert_report_helper_.reset(new CertReportHelper(
std::move(ssl_cert_reporter), web_contents, request_url, ssl_info,
certificate_reporting::ErrorReport::INTERSTITIAL_SSL, overridable_,
- controller_->metrics_helper()));
+ controller()->metrics_helper()));
ssl_error_ui_.reset(new SSLErrorUI(request_url, cert_error, ssl_info,
options_mask, time_triggered,
- controller_.get()));
+ controller()));
// Creating an interstitial without showing (e.g. from chrome://interstitials)
// it leaks memory, so don't create it here.
@@ -182,10 +181,6 @@ SSLBlockingPage::~SSLBlockingPage() {
}
}
-void SSLBlockingPage::AfterShow() {
- controller_->set_interstitial_page(interstitial_page());
-}
-
void SSLBlockingPage::PopulateInterstitialStrings(
base::DictionaryValue* load_time_data) {
ssl_error_ui_->PopulateStringsForHTML(load_time_data);
« no previous file with comments | « chrome/browser/ssl/ssl_blocking_page.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698