Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2858)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_blocking_page.cc

Issue 2298613007: Use controller from SecurityInterstitialPage in derived classes (Closed)
Patch Set: Provide default impl for SecurityInterstitialPage::AfterShow Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
diff --git a/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc b/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
index ba9d936ae4222d382e9df637f9911ca3148daf38..e944af9613ae2866a57aec886acd27335ca73346 100644
--- a/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
+++ b/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
@@ -23,6 +23,7 @@
#include "base/time/time.h"
#include "base/values.h"
#include "chrome/browser/browser_process.h"
+#include "chrome/browser/interstitials/chrome_controller_client.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/renderer_preferences_util.h"
#include "chrome/browser/safe_browsing/threat_details.h"
@@ -236,12 +237,12 @@ void SafeBrowsingBlockingPage::CommandReceived(const std::string& page_cmd) {
switch (command) {
case security_interstitials::CMD_DO_REPORT: {
// User enabled SB Extended Reporting via the checkbox.
- SetReportingPreference(true);
+ controller()->SetReportingPreference(true);
break;
}
case security_interstitials::CMD_DONT_REPORT: {
// User disabled SB Extended Reporting via the checkbox.
- SetReportingPreference(false);
+ controller()->SetReportingPreference(false);
break;
}
case security_interstitials::CMD_OPEN_HELP_CENTER: {
@@ -259,7 +260,7 @@ void SafeBrowsingBlockingPage::CommandReceived(const std::string& page_cmd) {
}
case security_interstitials::CMD_OPEN_REPORTING_PRIVACY: {
// User pressed on the SB Extended Reporting "privacy policy" link.
- OpenExtendedReportingPrivacyPolicy();
+ controller()->OpenExtendedReportingPrivacyPolicy();
break;
}
case security_interstitials::CMD_PROCEED: {

Powered by Google App Engine
This is Rietveld 408576698