chrome/browser/safe_browsing/safe_browsing_blocking_page.h - Issue 2298613007: Use controller from SecurityInterstitialPage in derived classes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/safe_browsing_blocking_page.h

Issue 2298613007: Use controller from SecurityInterstitialPage in derived classes (Closed)

Patch Set: Provide default impl for SecurityInterstitialPage::AfterShow Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/safe_browsing/safe_browsing_blocking_page.h

diff --git a/chrome/browser/safe_browsing/safe_browsing_blocking_page.h b/chrome/browser/safe_browsing/safe_browsing_blocking_page.h

index 9770c71f107e387237402480419a27458326a8c9..13779f1f9cd50aee49d4b94f034ff595f98cf946 100644

--- a/chrome/browser/safe_browsing/safe_browsing_blocking_page.h

+++ b/chrome/browser/safe_browsing/safe_browsing_blocking_page.h

@@ -130,7 +130,6 @@ class SafeBrowsingBlockingPage : public SecurityInterstitialPage {

bool ShouldCreateNewNavigation() const override;

void PopulateInterstitialStrings(

base::DictionaryValue* load_time_data) override;

- void AfterShow() override {}

// After a safe browsing interstitial where the user opted-in to the

// report but clicked "proceed anyway", we delay the call to