Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: chrome/browser/interstitials/security_interstitial_page.h

Issue 2298613007: Use controller from SecurityInterstitialPage in derived classes (Closed)
Patch Set: Provide default impl for SecurityInterstitialPage::AfterShow Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/interstitials/security_interstitial_page.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/interstitials/security_interstitial_page.h
diff --git a/chrome/browser/interstitials/security_interstitial_page.h b/chrome/browser/interstitials/security_interstitial_page.h
index 94dd73886b17e94896b9955422493c43c11ae536..f013d9640449298550651d3fa862f241d534bb02 100644
--- a/chrome/browser/interstitials/security_interstitial_page.h
+++ b/chrome/browser/interstitials/security_interstitial_page.h
@@ -49,7 +49,7 @@ class SecurityInterstitialPage : public content::InterstitialPageDelegate {
// Gives an opportunity for child classes to react to Show() having run. The
// interstitial_page_ will now have a value.
- virtual void AfterShow() = 0;
+ virtual void AfterShow() {}
// InterstitialPageDelegate method:
std::string GetHTMLContents() override;
@@ -68,12 +68,12 @@ class SecurityInterstitialPage : public content::InterstitialPageDelegate {
// TODO(felt): Remove these. They are temporary methods, used to pass along
// calls to the |controller_| for subclasses that don't yet have their own
// ChromeControllerClients. crbug.com/488673
- void SetReportingPreference(bool report);
- void OpenExtendedReportingPrivacyPolicy();
security_interstitials::MetricsHelper* metrics_helper();
void set_metrics_helper(
std::unique_ptr<security_interstitials::MetricsHelper> metrics_helper);
+ ChromeControllerClient* controller();
+
private:
// The WebContents with which this interstitial page is
// associated. Not available in ~SecurityInterstitialPage, since it
« no previous file with comments | « no previous file | chrome/browser/interstitials/security_interstitial_page.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698