Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3148)

Unified Diff: chrome/browser/ssl/ssl_blocking_page.h

Issue 2298613007: Use controller from SecurityInterstitialPage in derived classes (Closed)
Patch Set: Provide default impl for SecurityInterstitialPage::AfterShow Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ssl/captive_portal_blocking_page.h ('k') | chrome/browser/ssl/ssl_blocking_page.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ssl/ssl_blocking_page.h
diff --git a/chrome/browser/ssl/ssl_blocking_page.h b/chrome/browser/ssl/ssl_blocking_page.h
index 1353e9a04e2325436ec4313b6c18e8bd5c5f4c75..feb7966f001337a57569c74e394185f9cde8f871 100644
--- a/chrome/browser/ssl/ssl_blocking_page.h
+++ b/chrome/browser/ssl/ssl_blocking_page.h
@@ -36,7 +36,6 @@ class SSLErrorUI;
}
class CertReportHelper;
-class ChromeControllerClient;
class SSLUITest;
// This class is responsible for showing/hiding the interstitial page that is
@@ -88,7 +87,6 @@ class SSLBlockingPage : public SecurityInterstitialPage {
bool ShouldCreateNewNavigation() const override;
void PopulateInterstitialStrings(
base::DictionaryValue* load_time_data) override;
- void AfterShow() override;
private:
void NotifyDenyCertificate();
@@ -101,7 +99,6 @@ class SSLBlockingPage : public SecurityInterstitialPage {
// expired.
const bool expired_but_previously_allowed_;
- std::unique_ptr<ChromeControllerClient> controller_;
std::unique_ptr<security_interstitials::SSLErrorUI> ssl_error_ui_;
std::unique_ptr<CertReportHelper> cert_report_helper_;
« no previous file with comments | « chrome/browser/ssl/captive_portal_blocking_page.h ('k') | chrome/browser/ssl/ssl_blocking_page.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698