Get rid of remaining uses of AXObject::elementRect

Get rid of remaining uses of AXObject::elementRect

This change is mostly refactoring and deleting with just a bit of new code.

There were a few places we were still using AXObject::elementRect inside of
Blink. Fix those and replace them with the new AXObject::getRelativeBounds or
a new function AXObject::getBoundsInFrameCoordinates for cases where we do
need absolute frame-relative coordates.

There were a few subclasses of AXMockObject that didn't support
getRelativeBounds yet but weren't migrated earlier because they had no
test coverage for their bounding rects. Fix those and add new tests to
cover them.

To make it easier to implement those, I moved the implementation of
getRelativeBounds from AXLayoutObject to AXObject, and made it dependent
on a new protected virtual method layoutObjectForRelativeBounds().
If a subclass of AXObject wants its bounds computed all it needs to
do is implement layoutObjectForRelativeBounds() and the rest is done
for it.

BUG=618120
Committed: https://crrev.com/1da67644e2628c06055962acb243c3c058b68c20
Cr-Commit-Position: refs/heads/master@{#417028}

[dmazzoni, 2016-08-26 21:22:59]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[dmazzoni, 2016-08-26 21:23:22]

dmazzoni@chromium.org changed reviewers:
+ aboxhall@chromium.org

[dmazzoni, 2016-08-26 21:23:23]

Alice, could you take a look first before I loop in owners?

[commit-bot: I haz the power, 2016-08-26 21:23:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dmazzoni, 2016-08-26 21:25:10]

Description was changed from

==========
Get rid of remaining uses of AXObject::elementRect

There were a few places we were still using AXObject::elementRect inside of
Blink. Fix those and replace them with the new AXObject::getRelativeBounds or
a new function AXObject::getBoundsInFrameCoordinates for cases where we do
need absolute frame-relative coordates.

There were a few subclasses of AXMockObject that didn't support
getRelativeBounds yet but weren't migrated earlier because they had no
test coverage for their bounding rects. Fix those and add new tests to
cover them.

BUG=618120
==========

to

==========
Get rid of remaining uses of AXObject::elementRect

This change is mostly refactoring and deleting with just a bit of new code.

There were a few places we were still using AXObject::elementRect inside of
Blink. Fix those and replace them with the new AXObject::getRelativeBounds or
a new function AXObject::getBoundsInFrameCoordinates for cases where we do
need absolute frame-relative coordates.

There were a few subclasses of AXMockObject that didn't support
getRelativeBounds yet but weren't migrated earlier because they had no
test coverage for their bounding rects. Fix those and add new tests to
cover them.

To make it easier to implement those, I moved the implementation of
getRelativeBounds from AXLayoutObject to AXObject, and made it dependent
on a new protected virtual method layoutObjectForRelativeBounds().
If a subclass of AXObject wants its bounds computed all it needs to
do is implement layoutObjectForRelativeBounds() and the rest is done
for it.

BUG=618120
==========

[aboxhall, 2016-08-26 22:44:46]

lgtm

https://codereview.chromium.org/2287433003/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/accessibility/AXSpinButton.cpp (right):

https://codereview.chromium.org/2287433003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/accessibility/AXSpinButton.cpp:127: // FIXME:
This logic should exist in the layout tree or elsewhere, but there is no
Is this FIXME still current?

[commit-bot: I haz the power, 2016-08-27 00:05:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-27 00:05:08]

Dry run: This issue passed the CQ dry run.

[dmazzoni, 2016-08-29 23:17:06]

https://codereview.chromium.org/2287433003/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/accessibility/AXSpinButton.cpp (right):

https://codereview.chromium.org/2287433003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/accessibility/AXSpinButton.cpp:127: // FIXME:
This logic should exist in the layout tree or elsewhere, but there is no
On 2016/08/26 at 22:44:46, aboxhall wrote:
> Is this FIXME still current?

Yes - we're just dividing the height in half to get the
upper vs lower spin button part. It'd be nice if there
was an API for this but it seems pretty unlikely to break.

[dmazzoni, 2016-08-29 23:17:10]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2016-08-29 23:59:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 03:41:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 03:41:27]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dmazzoni, 2016-08-30 06:13:52]

dmazzoni@chromium.org changed reviewers:
+ dglazkov@chromium.org

[dmazzoni, 2016-08-30 06:13:53]

+dglazkov for public/web/

[dglazkov, 2016-09-06 23:33:25]

lgtm

[dmazzoni, 2016-09-07 17:46:33]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 17:46:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 19:26:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 19:26:24]

Dry run: This issue passed the CQ dry run.

[dmazzoni, 2016-09-07 19:27:02]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2016-09-07 19:27:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
dglazkov@chromium.org, aboxhall@chromium.org
Link to the patchset: https://codereview.chromium.org/2287433003/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2016-09-07 19:27:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 19:34:43]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-07 19:38:05]

Description was changed from

==========
Get rid of remaining uses of AXObject::elementRect

This change is mostly refactoring and deleting with just a bit of new code.

There were a few places we were still using AXObject::elementRect inside of
Blink. Fix those and replace them with the new AXObject::getRelativeBounds or
a new function AXObject::getBoundsInFrameCoordinates for cases where we do
need absolute frame-relative coordates.

There were a few subclasses of AXMockObject that didn't support
getRelativeBounds yet but weren't migrated earlier because they had no
test coverage for their bounding rects. Fix those and add new tests to
cover them.

To make it easier to implement those, I moved the implementation of
getRelativeBounds from AXLayoutObject to AXObject, and made it dependent
on a new protected virtual method layoutObjectForRelativeBounds().
If a subclass of AXObject wants its bounds computed all it needs to
do is implement layoutObjectForRelativeBounds() and the rest is done
for it.

BUG=618120
==========

to

==========
Get rid of remaining uses of AXObject::elementRect

This change is mostly refactoring and deleting with just a bit of new code.

There were a few places we were still using AXObject::elementRect inside of
Blink. Fix those and replace them with the new AXObject::getRelativeBounds or
a new function AXObject::getBoundsInFrameCoordinates for cases where we do
need absolute frame-relative coordates.

There were a few subclasses of AXMockObject that didn't support
getRelativeBounds yet but weren't migrated earlier because they had no
test coverage for their bounding rects. Fix those and add new tests to
cover them.

To make it easier to implement those, I moved the implementation of
getRelativeBounds from AXLayoutObject to AXObject, and made it dependent
on a new protected virtual method layoutObjectForRelativeBounds().
If a subclass of AXObject wants its bounds computed all it needs to
do is implement layoutObjectForRelativeBounds() and the rest is done
for it.

BUG=618120

Committed: https://crrev.com/1da67644e2628c06055962acb243c3c058b68c20
Cr-Commit-Position: refs/heads/master@{#417028}
==========

[commit-bot: I haz the power, 2016-09-07 19:38:07]

Patchset 2 (id:??) landed as
https://crrev.com/1da67644e2628c06055962acb243c3c058b68c20
Cr-Commit-Position: refs/heads/master@{#417028}