third_party/WebKit/Source/modules/accessibility/AXMenuListOption.h - Issue 2287433003: Get rid of remaining uses of AXObject::elementRect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXMenuListOption.h

Issue 2287433003: Get rid of remaining uses of AXObject::elementRect (Closed)

Patch Set: Rebase Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp ('k') | third_party/WebKit/Source/modules/accessibility/AXMenuListOption.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/accessibility/AXMenuListOption.h

diff --git a/third_party/WebKit/Source/modules/accessibility/AXMenuListOption.h b/third_party/WebKit/Source/modules/accessibility/AXMenuListOption.h

index 26f44ddca0593873d2aa5a4f4051c2605934c734..a0115c34bf3191e8a84aa37d9dc6e04fe93e524f 100644

--- a/third_party/WebKit/Source/modules/accessibility/AXMenuListOption.h

+++ b/third_party/WebKit/Source/modules/accessibility/AXMenuListOption.h

@@ -59,7 +59,7 @@ private:

bool isSelected() const override;

void setSelected(bool) override;

bool canSetSelectedAttribute() const override;

- LayoutRect elementRect() const override;

+ void getRelativeBounds(AXObject** outContainer, FloatRect& outBoundsInContainer, SkMatrix44& outContainerTransform) const override;

String textAlternative(bool recursive, bool inAriaLabelledByTraversal, AXObjectSet& visited, AXNameFrom&, AXRelatedObjectVector*, NameSources*) const override;

bool computeAccessibilityIsIgnored(IgnoredReasons* = nullptr) const override;