third_party/WebKit/Source/modules/accessibility/AXTableHeaderContainer.cpp - Issue 2287433003: Get rid of remaining uses of AXObject::elementRect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXTableHeaderContainer.cpp

Issue 2287433003: Get rid of remaining uses of AXObject::elementRect (Closed)

Patch Set: Rebase Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/accessibility/AXTableHeaderContainer.h ('k') | third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DAPITest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/accessibility/AXTableHeaderContainer.cpp

diff --git a/third_party/WebKit/Source/modules/accessibility/AXTableHeaderContainer.cpp b/third_party/WebKit/Source/modules/accessibility/AXTableHeaderContainer.cpp

index ba85fb7720b37d5261f967504812e57be9284cd6..541df9a82628632d59e5805f804a61251333ae59 100644

--- a/third_party/WebKit/Source/modules/accessibility/AXTableHeaderContainer.cpp

+++ b/third_party/WebKit/Source/modules/accessibility/AXTableHeaderContainer.cpp

@@ -46,12 +46,6 @@ AXTableHeaderContainer* AXTableHeaderContainer::create(AXObjectCacheImpl& axObje

return new AXTableHeaderContainer(axObjectCache);

}

-LayoutRect AXTableHeaderContainer::elementRect() const

- // this will be filled in when addChildren is called

- return m_headerRect;

bool AXTableHeaderContainer::computeAccessibilityIsIgnored(IgnoredReasons* ignoredReasons) const

{

if (!m_parent)

@@ -76,10 +70,6 @@ void AXTableHeaderContainer::addChildren()

return;

toAXTable(m_parent)->columnHeaders(m_children);

- unsigned length = m_children.size();

- for (unsigned k = 0; k < length; ++k)

- m_headerRect.unite(m_children[k]->elementRect());

}

} // namespace blink