Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(829)

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXObject.h

Issue 2287433003: Get rid of remaining uses of AXObject::elementRect (Closed)
Patch Set: Rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/accessibility/AXObject.h
diff --git a/third_party/WebKit/Source/modules/accessibility/AXObject.h b/third_party/WebKit/Source/modules/accessibility/AXObject.h
index 2381a057ede23042b919e3240545aed860bf8314..6b06b0b23665f7672a91faea80c3dbfa0d659af8 100644
--- a/third_party/WebKit/Source/modules/accessibility/AXObject.h
+++ b/third_party/WebKit/Source/modules/accessibility/AXObject.h
@@ -838,23 +838,8 @@ public:
bool containerLiveRegionAtomic() const;
bool containerLiveRegionBusy() const;
- // Location and click point in frame-relative coordinates. DEPRECATED, to be
- // replaced by getRelativeBounds.
- virtual LayoutRect elementRect() const { return m_explicitElementRect; }
- void setElementRect(LayoutRect r, AXObject* container)
- {
- m_explicitElementRect = r;
- m_explicitContainerID = container->axObjectID();
- }
- virtual void markCachedElementRectDirty() const;
- virtual IntPoint clickPoint();
-
- // Transformation relative to the parent frame, if local (otherwise returns identity).
- // DEPRECATED, to be replaced by getRelativeBounds.
- virtual SkMatrix44 transformFromLocalParentFrame() const;
-
- // NEW bounds calculation interface. Every object's bounding box is returned
- // relative to a container object (which is guaranteed to be an ancestor) and
+ // Every object's bounding box is returned relative to a
+ // container object (which is guaranteed to be an ancestor) and
// optionally a transformation matrix that needs to be applied too.
// To compute the absolute bounding box of an element, start with its
// boundsInContainer and apply the transform. Then as long as its container is
@@ -863,6 +848,16 @@ public:
// Do this until you reach the root of the tree.
virtual void getRelativeBounds(AXObject** outContainer, FloatRect& outBoundsInContainer, SkMatrix44& outContainerTransform) const;
+ // Get the bounds in frame-relative coordinates as a LayoutRect.
+ LayoutRect getBoundsInFrameCoordinates() const;
+
+ // Explicitly set an object's bounding rect and offset container.
+ void setElementRect(LayoutRect r, AXObject* container)
+ {
+ m_explicitElementRect = r;
+ m_explicitContainerID = container->axObjectID();
+ }
+
// Hit testing.
// Called on the root AX object to return the deepest available element.
virtual AXObject* accessibilityHitTest(const IntPoint&) const { return 0; }
@@ -960,7 +955,6 @@ public:
static bool isARIAControl(AccessibilityRole);
static bool isARIAInput(AccessibilityRole);
static AccessibilityRole ariaRoleToWebCoreRole(const String&);
- static IntRect boundingBoxForQuads(LayoutObject*, const Vector<FloatQuad>&);
static const AtomicString& roleName(AccessibilityRole);
static const AtomicString& internalRoleName(AccessibilityRole);
static bool isInsideFocusableElementOrARIAWidget(const Node&);
@@ -992,6 +986,8 @@ protected:
AccessibilityRole buttonRoleType() const;
+ virtual LayoutObject* layoutObjectForRelativeBounds() const { return nullptr; }
+
mutable Member<AXObject> m_parent;
// The following cached attribute values (the ones starting with m_cached*)

Powered by Google App Engine
This is Rietveld 408576698