Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXLayoutObject.h

Issue 2287433003: Get rid of remaining uses of AXObject::elementRect (Closed)
Patch Set: Rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/accessibility/AXLayoutObject.h
diff --git a/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.h b/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.h
index c225fd8450dc155dd2ab35330e7cd5dfba518ed9..ac4e17174a8e485a4071d3a1b9bbac62dd8129b6 100644
--- a/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.h
+++ b/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.h
@@ -57,22 +57,15 @@ public:
// Public, overridden from AXObject.
LayoutObject* getLayoutObject() const final { return m_layoutObject; }
- LayoutRect elementRect() const override;
LayoutBoxModelObject* getLayoutBoxModelObject() const;
- SkMatrix44 transformFromLocalParentFrame() const override;
ScrollableArea* getScrollableAreaIfScrollable() const final;
- void getRelativeBounds(AXObject** outContainer, FloatRect& outBoundsInContainer, SkMatrix44& outContainerTransform) const override;
AccessibilityRole determineAccessibilityRole() override;
AccessibilityRole nativeAccessibilityRoleIgnoringAria() const override;
- void checkCachedElementRect() const;
- void updateCachedElementRect() const;
protected:
LayoutObject* m_layoutObject;
- mutable LayoutRect m_cachedElementRect;
- mutable LayoutRect m_cachedFrameRect;
- mutable IntPoint m_cachedScrollPosition;
- mutable bool m_cachedElementRectDirty;
+
+ LayoutObject* layoutObjectForRelativeBounds() const override { return m_layoutObject; }
//
// Overridden from AXObject.
@@ -151,10 +144,6 @@ protected:
AXRange selectionUnderObject() const override;
void setSelection(const AXRange&) override;
- // Location and click point in frame-relative coordinates.
- void markCachedElementRectDirty() const override;
- IntPoint clickPoint() override;
-
// Hit testing.
AXObject* accessibilityHitTest(const IntPoint&) const override;
AXObject* elementAccessibilityHitTest(const IntPoint&) const override;

Powered by Google App Engine
This is Rietveld 408576698